zacharymorn commented on code in PR #13238:
URL: https://github.com/apache/lucene/pull/13238#discussion_r1550291935


##########
lucene/MIGRATE.md:
##########
@@ -185,6 +185,34 @@ enum.
 
 `IOContext#LOAD` has been replaced with `IOContext#PRELOAD`.
 
+### IndexSearch#search(Query, Collector) being deprecated in favor of 
IndexSearcher#search(Query, CollectorManager) (LUCENE-10002)
+
+`IndexSearch#search(Query, Collector)` is now being deprecated in favor of 
`IndexSearcher#search(Query, CollectorManager)`,

Review Comment:
   Thanks Mike for the suggestion! I wonder if `has been deprecated` (instead 
of `has been removed`) would be better here, if for some reasons we are not 
able to completely delete the method and its usage by `10.0.0`? `deprecated` 
also sometimes imply `removed`, so we don't need to update this entry either if 
we are able to remove the method by `10.0.0`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to