jpountz commented on issue #13241: URL: https://github.com/apache/lucene/issues/13241#issuecomment-2033982972
It's true that these things can still use amounts of heap that are not completely negligible, but I wonder if it's a good reason to preserve this interface. Doc values too can use non-negligible amounts of heap if you have many fields that are multi-valued and/or use dictionary compression. From a quick look, none of Elasticsearch, Solr, OpenSearch and luceneserver take advantage of this interface on `KnnVectorsReader`. (I searched for calls to `CodecReader#getVectorReader`, which are necessary to get an object that you can call `#ramBytesUsed()` on.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
