[GitHub] [lucene] jpountz commented on a diff in pull request #12111: SimpleText codec to support writing byte vectors

jpountz commented on code in PR #12111: URL: https://github.com/apache/lucene/pull/12111#discussion_r1086310610 ## lucene/core/src/java/org/apache/lucene/codecs/BufferingKnnVectorsWriter.java: ## @@ -39,79 +37,81 @@ * @lucene.experimental */ public abstract class BufferingK

[GitHub] [lucene] javanna commented on a diff in pull request #12111: SimpleText codec to support writing byte vectors

javanna commented on code in PR #12111: URL: https://github.com/apache/lucene/pull/12111#discussion_r1086409971 ## lucene/core/src/java/org/apache/lucene/codecs/BufferingKnnVectorsWriter.java: ## @@ -39,79 +37,81 @@ * @lucene.experimental */ public abstract class BufferingK

[GitHub] [lucene] javanna merged pull request #12111: SimpleText codec to support writing byte vectors

javanna merged PR #12111: URL: https://github.com/apache/lucene/pull/12111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] javanna merged pull request #12110: Fix flaky TestHnswByteVectorGraph.testSortedAndUnsortedIndicesReturnSameResults test

javanna merged PR #12110: URL: https://github.com/apache/lucene/pull/12110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] javanna opened a new pull request, #12112: SimpleText codec to support writing byte vectors (#12111)

javanna opened a new pull request, #12112: URL: https://github.com/apache/lucene/pull/12112 A recent test failure signaled that when the simple text codec was randomly selected, byte vectors could not be written. This commit addressed that by adding support for writing byte vectors to Simpl

[GitHub] [lucene] javanna merged pull request #12112: SimpleText codec to support writing byte vectors (#12111)

javanna merged PR #12112: URL: https://github.com/apache/lucene/pull/12112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] alessandrobenedetti commented on pull request #12048: Move HNSW parameters to the HnswGraphBuilder class

alessandrobenedetti commented on PR #12048: URL: https://github.com/apache/lucene/pull/12048#issuecomment-1403387891 @msokolov do you see any reason why we shouldn't do it? because I reviewed the pull request Daniele is going to publish (Word2Vec for synonyms generation: https://www.youtub

[GitHub] [lucene] msokolov commented on pull request #12048: Move HNSW parameters to the HnswGraphBuilder class

msokolov commented on PR #12048: URL: https://github.com/apache/lucene/pull/12048#issuecomment-1403475767 I would say let's make the changes when we can see the purpose of doing it? So, if Daniele is planning to make use of this in an upcoming PR, let's just incorporate the change into

[GitHub] [lucene] benwtrent commented on a diff in pull request #12111: SimpleText codec to support writing byte vectors

benwtrent commented on code in PR #12111: URL: https://github.com/apache/lucene/pull/12111#discussion_r1086603790 ## lucene/core/src/java/org/apache/lucene/codecs/BufferingKnnVectorsWriter.java: ## @@ -161,77 +161,113 @@ public int advance(int target) throws IOException { }

[GitHub] [lucene] alessandrobenedetti commented on pull request #12048: Move HNSW parameters to the HnswGraphBuilder class

alessandrobenedetti commented on PR #12048: URL: https://github.com/apache/lucene/pull/12048#issuecomment-1403736061 Ok, that's fine! @dantuzi you can cancel this PR and just include the change in the final PR. Thanks @msokolov for the suggestion! -- This is an automated message fr

[GitHub] [lucene] dnhatn commented on issue #11428: Handle soft deletes via LiveDocsFormat [LUCENE-10392]

dnhatn commented on issue #11428: URL: https://github.com/apache/lucene/issues/11428#issuecomment-1404033931 @zacharymorn Thank you for looking into the issue. The first proposals of the API: https://issues.apache.org/jira/browse/LUCENE-8198 and https://issues.apache.org/jira/browse/