msokolov commented on PR #12048: URL: https://github.com/apache/lucene/pull/12048#issuecomment-1403475767
I would say let's make the changes when we can see the purpose of doing it? So, if Daniele is planning to make use of this in an upcoming PR, let's just incorporate the change into that? On Wed, Jan 25, 2023 at 10:22 AM Alessandro Benedetti < ***@***.***> wrote: > @msokolov <https://github.com/msokolov> do you see any reason why we > shouldn't do it? because I reviewed the pull request Daniele is going to > publish (Word2Vec for synonyms generation: > https://www.youtube.com/watch?v=rKYJQhZxQFQ&t=469s) and having those > constants in the HNSW Graph builder facilitates the things. > Furthermore, those constants in terms of responsibility affect how the > graph is built(more than the codec), so in terms of cohesion of the class, > it seems reasonable to me for them to be in the HNSW Graph builder. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene/pull/12048#issuecomment-1403387891>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAHHUQLHCOE5VCFT7IE7JUDWUD5EPANCNFSM6AAAAAATM745TY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
