alessandrobenedetti commented on PR #12048: URL: https://github.com/apache/lucene/pull/12048#issuecomment-1403387891
@msokolov do you see any reason why we shouldn't do it? because I reviewed the pull request Daniele is going to publish (Word2Vec for synonyms generation: https://www.youtube.com/watch?v=rKYJQhZxQFQ&t=469s) and having those constants in the HNSW Graph builder facilitates the things. Furthermore, those constants in terms of responsibility affect how the graph is built(more than the codec), so in terms of cohesion of the class, it seems reasonable to me for them to be in the HNSW Graph builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
