javanna commented on code in PR #12111:
URL: https://github.com/apache/lucene/pull/12111#discussion_r1086409971
##########
lucene/core/src/java/org/apache/lucene/codecs/BufferingKnnVectorsWriter.java:
##########
@@ -39,79 +37,81 @@
* @lucene.experimental
*/
public abstract class BufferingKnnVectorsWriter extends KnnVectorsWriter {
- private final List<FieldWriter> fields = new ArrayList<>();
+ private final List<FieldWriter<?>> fields = new ArrayList<>();
/** Sole constructor */
protected BufferingKnnVectorsWriter() {}
@Override
- public KnnFieldVectorsWriter<float[]> addField(FieldInfo fieldInfo) throws
IOException {
- FieldWriter newField = new FieldWriter(fieldInfo);
+ public KnnFieldVectorsWriter<?> addField(FieldInfo fieldInfo) throws
IOException {
Review Comment:
yes that's a good point and we should probably look at #11758 as a whole and
see what we can improve further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
