benwtrent commented on code in PR #12111: URL: https://github.com/apache/lucene/pull/12111#discussion_r1086603790
########## lucene/core/src/java/org/apache/lucene/codecs/BufferingKnnVectorsWriter.java: ########## @@ -161,77 +161,113 @@ public int advance(int target) throws IOException { } } + /** Sorting FloatVectorValues that iterate over documents in the order of the provided sortMap */ Review Comment: ``` /** Sorting SortingByteVectorValues that iterate over documents in the order of the provided sortMap */ ``` Comment is incorrect. But not a huge deal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org