jpountz opened a new pull request, #1019:
URL: https://github.com/apache/lucene/pull/1019
This method is called from `addIndexes` and should be synchronized so that it
would see consistent data structures in case of concurrent indexing that
would
be introducing new fields.
I hit
[
https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566212#comment-17566212
]
Robert Muir commented on LUCENE-10471:
--
My questions are still unanswered. Please
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566220#comment-17566220
]
Robert Muir commented on LUCENE-10577:
--
{quote}
I tried looking at how DocValues a
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566223#comment-17566223
]
Robert Muir commented on LUCENE-10577:
--
By the way, if the right answer is that re
jtibshirani commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r919842519
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -102,9 +104,22 @@ private class FieldsWriter extends KnnVectorsWriter {
mocobeta opened a new pull request, #41:
URL: https://github.com/apache/lucene-jira-archive/pull/41
Close #36
`jira2github_import.py` processes Jira dump files one by one and does not
call any HTTP APIs. It should be able to parallelize it with
[multiprocessing](https://docs.python.
mocobeta opened a new pull request, #42:
URL: https://github.com/apache/lucene-jira-archive/pull/42
This is a small follow-up for #40.
sh
mocobeta merged PR #42:
URL: https://github.com/apache/lucene-jira-archive/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lu
[
https://issues.apache.org/jira/browse/LUCENE-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566298#comment-17566298
]
Lu Xugang commented on LUCENE-10397:
It seems like this issue has been resolved aft
[
https://issues.apache.org/jira/browse/LUCENE-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566298#comment-17566298
]
Lu Xugang edited comment on LUCENE-10397 at 7/13/22 12:33 PM:
---
mikemccand opened a new pull request, #43:
URL: https://github.com/apache/lucene-jira-archive/pull/43
More PNP polishing:
* Make Linked Issues more compact so it's just LUCENE-NNN as a link
* The "Legacy Jira" footer in each migrated comment is now a link back to
the exact comment
dsmiley commented on code in PR #821:
URL: https://github.com/apache/lucene/pull/821#discussion_r920037120
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -1091,6 +1091,24 @@ protected FieldHighlighter getFieldHighlighter(
mikemccand commented on PR #43:
URL:
https://github.com/apache/lucene-jira-archive/pull/43#issuecomment-1183200274
Now the comment looks like this:
:
logger.error(f"Failed to conv
mikemccand commented on code in PR #43:
URL: https://github.com/apache/lucene-jira-archive/pull/43#discussion_r920071047
##
migration/src/jira2github_import.py:
##
@@ -146,8 +146,10 @@ def comment_author(author_name, author_dispname):
logger.error(f"Failed to co
mocobeta commented on PR #41:
URL:
https://github.com/apache/lucene-jira-archive/pull/41#issuecomment-1183234776
Works fine for me - it now processes the whole Jira dump in about 80 minutes
with four workers.
```
python src/jira2github_import.py --min 1 --max 10648 --num_workers 4
mocobeta commented on PR #41:
URL:
https://github.com/apache/lucene-jira-archive/pull/41#issuecomment-1183240812
@mikemccand just to let you know, I'm going to merge this tomorrow (in JST)
so that we are able to iterate conversion tests more often.
--
This is an automated message from th
luyuncheng commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r920106561
##
lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressionMode.java:
##
@@ -257,9 +270,13 @@ private static class DeflateCompressor extends Compressor {
luyuncheng commented on PR #987:
URL: https://github.com/apache/lucene/pull/987#issuecomment-1183266339
> we prefer to fork the code so that old codecs still rely on the unchanged
code (which should move to lucene/backward-codecs)
Thanks for the your advice @jpountz , i think it is
luyuncheng commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r920106561
##
lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressionMode.java:
##
@@ -257,9 +270,13 @@ private static class DeflateCompressor extends Compressor {
mocobeta commented on PR #41:
URL:
https://github.com/apache/lucene-jira-archive/pull/41#issuecomment-1183303117
This code shares a Logger object between workers, that seems to work on
Linux but might not work on windows.
```
# The worker configuration is done at the start of the work
mikemccand commented on code in PR #43:
URL: https://github.com/apache/lucene-jira-archive/pull/43#discussion_r920189990
##
migration/src/jira2github_import.py:
##
@@ -146,8 +146,10 @@ def comment_author(author_name, author_dispname):
logger.error(f"Failed to co
[
https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566410#comment-17566410
]
Nathan Meisels commented on LUCENE-10650:
-
For future reference seems like if y
[
https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566410#comment-17566410
]
Nathan Meisels edited comment on LUCENE-10650 at 7/13/22 4:45 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566410#comment-17566410
]
Nathan Meisels edited comment on LUCENE-10650 at 7/13/22 4:45 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566422#comment-17566422
]
Adrien Grand commented on LUCENE-10650:
---
Indeed Elasticsearch would change the af
gsmiller opened a new pull request, #1020:
URL: https://github.com/apache/lucene/pull/1020
### Description (or a Jira issue link if you have one)
I'm coming back to work on LUCENE-10207, and one thing I found while working
on that is that DocValuesRewriteMethod doesn't support `scoreS
cpoerschke merged PR #821:
URL: https://github.com/apache/lucene/pull/821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
[
https://issues.apache.org/jira/browse/LUCENE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566441#comment-17566441
]
ASF subversion and git services commented on LUCENE-10523:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566443#comment-17566443
]
ASF subversion and git services commented on LUCENE-10523:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved LUCENE-10523.
--
Fix Version/s: 10.0 (main)
9.3
Resolution: Fixed
>
mikemccand merged PR #1012:
URL: https://github.com/apache/lucene/pull/1012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
[
https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566445#comment-17566445
]
Julie Tibshirani commented on LUCENE-10592:
---
This change makes sense to me to
[
https://issues.apache.org/jira/browse/LUCENE-10648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566444#comment-17566444
]
ASF subversion and git services commented on LUCENE-10648:
--
Co
jtibshirani commented on code in PR #992:
URL: https://github.com/apache/lucene/pull/992#discussion_r920371282
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##
@@ -24,28 +24,40 @@
import org.apache.lucene.index.DocIDMerger;
import org.apache.lucene.in
jtibshirani commented on PR #992:
URL: https://github.com/apache/lucene/pull/992#issuecomment-1183533308
👍 I resolved comments about `flush`. I don't have remaining high-level
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
[
https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566445#comment-17566445
]
Julie Tibshirani edited comment on LUCENE-10592 at 7/13/22 6:16 PM:
-
gsmiller commented on PR #1020:
URL: https://github.com/apache/lucene/pull/1020#issuecomment-1183535216
Hmm... looks like a test failed but it looks unrelated? Unlucky random test?
Will look a bit more.
--
This is an automated message from the Apache Git Service.
To respond to the message
mikemccand merged PR #43:
URL: https://github.com/apache/lucene-jira-archive/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566481#comment-17566481
]
Julie Tibshirani commented on LUCENE-10577:
---
I don't feel strongly about havi
nknize commented on code in PR #1017:
URL: https://github.com/apache/lucene/pull/1017#discussion_r920466302
##
lucene/core/src/java/org/apache/lucene/document/ShapeDocValuesField.java:
##
@@ -0,0 +1,844 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566498#comment-17566498
]
Michael Sokolov commented on LUCENE-10577:
--
I'm also not sure about Codec para
gsmiller opened a new pull request, #1021:
URL: https://github.com/apache/lucene/pull/1021
### Description (or a Jira issue link if you have one)
This is the last bit of work needed in LUCENE-10603 to actually remove the
definition of `SSDV#NO_MORE_ORDS` and stop returning it from `SS
msokolov commented on issue #37:
URL:
https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1183704949
Maybe somebody did this
https://confluence.atlassian.com/jirakb/how-to-set-the-starting-issue-number-for-a-project-318669643.html
--
This is an automated message from the
jpountz commented on code in PR #1021:
URL: https://github.com/apache/lucene/pull/1021#discussion_r920549702
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java:
##
@@ -1055,12 +1051,9 @@ public long cost() {
@Override
public long n
shahrs87 commented on PR #907:
URL: https://github.com/apache/lucene/pull/907#issuecomment-1183747929
Thank you @jpountz for being so patient with me. I tried your above
suggestion and hit the following problem.
Locally I removed the following check from BloomFilteringPostingsFormat.java
[
https://issues.apache.org/jira/browse/LUCENE-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566560#comment-17566560
]
Greg Miller commented on LUCENE-10632:
--
Bringing a conversation about this issue w
[
https://issues.apache.org/jira/browse/LUCENE-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10632:
-
Component/s: modules/facet
> Change getAllChildren to return all children regardless of the cou
gsmiller commented on code in PR #1021:
URL: https://github.com/apache/lucene/pull/1021#discussion_r920598336
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java:
##
@@ -1055,12 +1051,9 @@ public long cost() {
@Override
public long
mocobeta merged PR #41:
URL: https://github.com/apache/lucene-jira-archive/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lu
mocobeta closed issue #36: Can we parallelize the converter script?
URL: https://github.com/apache/lucene-jira-archive/issues/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
gsmiller merged PR #1021:
URL: https://github.com/apache/lucene/pull/1021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566614#comment-17566614
]
ASF subversion and git services commented on LUCENE-10603:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10603.
--
Resolution: Fixed
> Improve iteration of ords for SortedSetDocValues
> --
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566615#comment-17566615
]
Greg Miller commented on LUCENE-10603:
--
Shouldn't be any more to do on this now. R
LuXugang closed pull request #873: LUCENE-10397: KnnVectorQuery doesn't tie
break by doc ID
URL: https://github.com/apache/lucene/pull/873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
LuXugang commented on PR #873:
URL: https://github.com/apache/lucene/pull/873#issuecomment-1184023833
This issue has been resolved after https://github.com/apache/lucene/pull/926
merged .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Yuti-G commented on code in PR #1013:
URL: https://github.com/apache/lucene/pull/1013#discussion_r920790457
##
lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java:
##
@@ -254,14 +254,38 @@ protected void assertFloatValuesEquals(FacetResult a,
FacetResult b) {
Yuti-G commented on code in PR #1013:
URL: https://github.com/apache/lucene/pull/1013#discussion_r920793487
##
lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java:
##
@@ -254,14 +254,38 @@ protected void assertFloatValuesEquals(FacetResult a,
FacetResult b) {
Yuti-G commented on code in PR #1013:
URL: https://github.com/apache/lucene/pull/1013#discussion_r920790457
##
lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java:
##
@@ -254,14 +254,38 @@ protected void assertFloatValuesEquals(FacetResult a,
FacetResult b) {
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566481#comment-17566481
]
Julie Tibshirani edited comment on LUCENE-10577 at 7/14/22 6:56 AM:
-
63 matches
Mail list logo
