Yuti-G commented on code in PR #1013:
URL: https://github.com/apache/lucene/pull/1013#discussion_r920793487
##########
lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java:
##########
@@ -254,14 +254,38 @@ protected void assertFloatValuesEquals(FacetResult a,
FacetResult b) {
assertEquals(a.dim, b.dim);
Review Comment:
I think we do since this `assertFloatValuesEquals` method asserts labels and
values assuming they are in the same order, but `assertFacetResult` only assert
result contains all expected children without caring about the order. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
