jpountz opened a new pull request, #1019:
URL: https://github.com/apache/lucene/pull/1019

   This method is called from `addIndexes` and should be synchronized so that it
   would see consistent data structures in case of concurrent indexing that 
would
   be introducing new fields.
   
   I hit a rare test failure of `TestIndexRearranger` that I can only explain 
by this lack of locking:
   
   ```
   15:40:14    >     java.util.concurrent.ExecutionException: 
java.lang.NullPointerException: Cannot read field "numDimensions" because 
"props" is null
   15:40:14    >         at 
java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
   15:40:14    >         at 
java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
   15:40:14    >         at 
org.apache.lucene.misc.index.IndexRearranger.execute(IndexRearranger.java:98)
   15:40:14    >         at 
org.apache.lucene.misc.index.TestIndexRearranger.testRearrangeUsingBinaryDocValueSelector(TestIndexRearranger.java:97)
   15:40:14    >         at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   15:40:14    >         at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
   15:40:14    >         at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   15:40:14    >         at 
java.base/java.lang.reflect.Method.invoke(Method.java:568)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
   15:40:14    >         at 
[email protected]/org.junit.rules.RunRules.evaluate(RunRules.java:20)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
   15:40:14    >         at 
[email protected]/org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
   15:40:14    >         at 
[email protected]/org.junit.rules.RunRules.evaluate(RunRules.java:20)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
   15:40:14    >         at 
[email protected]/com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
   15:40:14    >         at java.base/java.lang.Thread.run(Thread.java:833)
   15:40:14    >
   15:40:14    >         Caused by:
   15:40:14    >         java.lang.NullPointerException: Cannot read field 
"numDimensions" because "props" is null
   15:40:14    >             at 
[email protected]/org.apache.lucene.index.FieldInfos$FieldNumbers.verifySameSchema(FieldInfos.java:459)
   15:40:14    >             at 
[email protected]/org.apache.lucene.index.FieldInfos$FieldNumbers.verifyFieldInfo(FieldInfos.java:359)
   15:40:14    >             at 
[email protected]/org.apache.lucene.index.IndexWriter.addIndexes(IndexWriter.java:3149)
   15:40:14    >             at 
org.apache.lucene.misc.index.IndexRearranger.addOneSegment(IndexRearranger.java:139)
   15:40:14    >             at 
org.apache.lucene.misc.index.IndexRearranger.lambda$execute$0(IndexRearranger.java:92)
   15:40:14    >             at 
java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   15:40:14    >             at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
   15:40:14    >             at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
   15:40:14    >             ... 1 more
   ```
   
   ### Description (or a Jira issue link if you have one)
   
   <!--
   If this is your first contribution to Lucene, please make sure you have 
reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to