dsmiley commented on code in PR #821:
URL: https://github.com/apache/lucene/pull/821#discussion_r920037120
##########
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##########
@@ -1091,6 +1091,24 @@ protected FieldHighlighter getFieldHighlighter(
getFormatter(field));
}
+ protected FieldHighlighter newFieldHighlighter(
Review Comment:
Is it "worth it" to do this when the `getFieldHighlighter` method, which
calls this, is already protected and is only 3 lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
