[
https://issues.apache.org/jira/browse/LUCENE-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10632:
---------------------------------
Component/s: modules/facet
> Change getAllChildren to return all children regardless of the count
> --------------------------------------------------------------------
>
> Key: LUCENE-10632
> URL: https://issues.apache.org/jira/browse/LUCENE-10632
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Yuting Gan
> Priority: Minor
>
> Currently, the getAllChildren functionality is implemented in a way that is
> similar to getTopChildren, where they only return children with count that is
> greater than zero.
> However, he original getTopChildren in RangeFacetCounts returned all children
> whether-or-not the count was zero. This actually has good use cases and we
> should continue supporting the feature in getAllChildren, so that we will not
> lose it after properly supporting getTopChildren in RangeFacetCounts.
> As discussed with [~gsmiller] in the [LUCENE-10614
> pr|https://github.com/apache/lucene/pull/974], allowing getAllChildren to
> behave differently from getTopChildren can actually be more helpful for
> users. If users want to get children with only positive count, we have
> getTopChildren supporting this behavior already. Therefore, the
> getAllChildren API should provide all children in all of the implementations,
> whether-or-not the count is zero.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
