[jira] [Commented] (LUCENE-10601) NullPointerException in Lucene Merge (v7.4)

2022-06-07 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550849#comment-17550849 ] Adrien Grand commented on LUCENE-10601: --- This is an old version, but this bit of

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-07 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1148322035 > Ok, if this is the case, then should we provide more out of the box `FacetSetMatcher` classes (like a `double` and a `long` implementation for starters) Yes absolutely! I wrote somewh

[GitHub] [lucene] craigtaverner opened a new pull request, #946: Add Tessellation monitor for easier debugging of triangulation algorithm

2022-06-07 Thread GitBox
craigtaverner opened a new pull request, #946: URL: https://github.com/apache/lucene/pull/946 ### Add Tessellation monitor for easier debugging of triangulation algorithm While working on https://github.com/apache/lucene/pull/933, it was found to be very, very helpful to visualize the

[GitHub] [lucene] gsmiller commented on pull request #927: LUCENE-10151: Adding Timeout Support to IndexSearcher

2022-06-07 Thread GitBox
gsmiller commented on PR #927: URL: https://github.com/apache/lucene/pull/927#issuecomment-1148572509 > [...] if you are running a distributed search, the search would fan out to shards, and there might be some networking and queueing involved. The time that matters to users is the total ti

[GitHub] [lucene] msokolov commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-06-07 Thread GitBox
msokolov commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r891169857 ## lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java: ## @@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) { return new BitSetI

[GitHub] [lucene] jpountz commented on pull request #921: LUCENE-10078: Enable merge-on-refresh by default.

2022-06-07 Thread GitBox
jpountz commented on PR #921: URL: https://github.com/apache/lucene/pull/921#issuecomment-1148717128 Good call, I added a warning to javadocs on `IndexWriterConfig#setMaxFullFlushMergeWaitMillis`. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [lucene] jpountz merged pull request #921: LUCENE-10078: Enable merge-on-refresh by default.

2022-06-07 Thread GitBox
jpountz merged PR #921: URL: https://github.com/apache/lucene/pull/921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[jira] [Commented] (LUCENE-10078) Enable merge-on-refresh by default?

2022-06-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551138#comment-17551138 ] ASF subversion and git services commented on LUCENE-10078: -- Co

[jira] [Commented] (LUCENE-10078) Enable merge-on-refresh by default?

2022-06-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551139#comment-17551139 ] ASF subversion and git services commented on LUCENE-10078: -- Co

[jira] [Resolved] (LUCENE-10078) Enable merge-on-refresh by default?

2022-06-07 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10078. --- Fix Version/s: 9.3 Resolution: Fixed > Enable merge-on-refresh by default? > ---

[GitHub] [lucene-site] gsmiller opened a new pull request, #65: Add Greg Miller as PMC member in whoweare.

2022-06-07 Thread GitBox
gsmiller opened a new pull request, #65: URL: https://github.com/apache/lucene-site/pull/65 Publish PMC list additions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [lucene-site] gsmiller merged pull request #65: Add Greg Miller as PMC member in whoweare.

2022-06-07 Thread GitBox
gsmiller merged PR #65: URL: https://github.com/apache/lucene-site/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] gsmiller commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-07 Thread GitBox
gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1148846237 OK, I've (somewhat) caught up on the conversation here and will follow up on my original questions/comments (but am not going to jump in right now on the latest API discussion). 1. I

[GitHub] [lucene-site] LuXugang merged pull request #66: Add Lu Xugang to committer list

2022-06-07 Thread GitBox
LuXugang merged PR #66: URL: https://github.com/apache/lucene-site/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] mdmarshmallow commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-07 Thread GitBox
mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1148871572 Hey Greg, I had a question about point 4. Are you saying we should have a separate hyper rectangle implementation in addition to facet sets in order to implement the R-tree and KD-tree

[jira] [Commented] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

2022-06-07 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551199#comment-17551199 ] Adrien Grand commented on LUCENE-10592: --- +1 In general I have a preference for "

[jira] [Commented] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

2022-06-07 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551231#comment-17551231 ] Mayya Sharipova commented on LUCENE-10592: -- Thanks Adrien, this is a great fee

[GitHub] [lucene] msokolov opened a new pull request, #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-06-07 Thread GitBox
msokolov opened a new pull request, #947: URL: https://github.com/apache/lucene/pull/947 This is PR #3 for this feature. It is very close to the previous one, just "rebased" on top of the Lucene93 Codec. In this PR I moved the new vector utility methods as package private in util.hnsw so th

[GitHub] [lucene] msokolov commented on a diff in pull request #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-06-07 Thread GitBox
msokolov commented on code in PR #947: URL: https://github.com/apache/lucene/pull/947#discussion_r891642180 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene92/Lucene92HnswVectorsWriter.java: ## @@ -129,6 +128,12 @@ public void writeField(FieldInfo fiel

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-07 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1149113591 > look forward to seeing the "range" implementation sketched out I pushed a commit w/ `RangeFacetSetMatcher` which is basically very similar to `HyperRectangle`, but w/ some different na

[GitHub] [lucene] mdmarshmallow commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-07 Thread GitBox
mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1149153824 I want to summarize the open questions we have right now to help figure out what we should do next: 1. Should we split the `ExactFSM` and range multidim implementations into separat

[jira] [Updated] (LUCENE-10602) Dynamic Index Cache Sizing

2022-06-07 Thread Chris Earle (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Earle updated LUCENE-10602: - Description: Working with Lucene's filter cache, it has become apparent that it can be an enor

[jira] [Created] (LUCENE-10602) Dynamic Index Cache Sizing

2022-06-07 Thread Chris Earle (Jira)
Chris Earle created LUCENE-10602: Summary: Dynamic Index Cache Sizing Key: LUCENE-10602 URL: https://issues.apache.org/jira/browse/LUCENE-10602 Project: Lucene - Core Issue Type: Improvement

[GitHub] [lucene] shahrs87 commented on pull request #897: LUCENE-10266 Move nearest-neighbor search on points to core

2022-06-07 Thread GitBox
shahrs87 commented on PR #897: URL: https://github.com/apache/lucene/pull/897#issuecomment-1149268621 @jpountz Addressed all of your previous comments. Please review again. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (LUCENE-10602) Dynamic Index Cache Sizing

2022-06-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551337#comment-17551337 ] Robert Muir commented on LUCENE-10602: -- I'm confused about "give GBs of heap back"

[jira] [Commented] (LUCENE-10602) Dynamic Index Cache Sizing

2022-06-07 Thread Chris Earle (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551338#comment-17551338 ] Chris Earle commented on LUCENE-10602: -- The GBs would be outside of defaults or in

[jira] [Commented] (LUCENE-10602) Dynamic Index Cache Sizing

2022-06-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551355#comment-17551355 ] Robert Muir commented on LUCENE-10602: -- well the default impl is a singleton, so e

[jira] [Created] (LUCENE-10603) Improve iteration of ords for SortedSetDocValues

2022-06-07 Thread Lu Xugang (Jira)
Lu Xugang created LUCENE-10603: -- Summary: Improve iteration of ords for SortedSetDocValues Key: LUCENE-10603 URL: https://issues.apache.org/jira/browse/LUCENE-10603 Project: Lucene - Core Issue

[GitHub] [lucene] iverase commented on pull request #933: LUCENE-10563: Unable to Tessellate polygon

2022-06-07 Thread GitBox
iverase commented on PR #933: URL: https://github.com/apache/lucene/pull/933#issuecomment-1149491161 @craigtaverner I forgot to ask you to add an entry in CHANGES.txt with regards this change. Could you do it? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] vigyasharma opened a new pull request, #948: Fix typo in PostingsReaderBase docstring

2022-06-07 Thread GitBox
vigyasharma opened a new pull request, #948: URL: https://github.com/apache/lucene/pull/948 The docstring for `PostingsReaderBase` seems to have an extra `{@link PostingsEnum}`. Minor change to fix it. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] zhaih commented on a diff in pull request #935: LUCENE-10599: Improve LogMergePolicy's handling of maxMergeSize.

2022-06-07 Thread GitBox
zhaih commented on code in PR #935: URL: https://github.com/apache/lucene/pull/935#discussion_r891966944 ## lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java: ## @@ -568,23 +568,41 @@ public MergeSpecification findMerges( // Finally, record all merges that