msokolov commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r891169857
##########
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##########
@@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) {
return new BitSetIterator(bitSets[contextOrd], cost[contextOrd]);
}
+ public void setBitSet(BitSet bitSet, int cost) {
+ bitSets[ord] = bitSet;
Review Comment:
Agreed, the approach of using `Bitset.of` to delegate creation of / access
to a bitset of matching docs for the filter Query seems very promising! It
would enable us to maintain the "user friendly" Query-based API while accessing
underlying Bits when they are available.
I also agree it makes sense to work on that change indepedently / in advance
of the tester changes, although it's a little paradoxical since I doubt we
would have been able to find this without having worked on the testing side
first! Still, to land these changes on lucene/main, I think putting in the
support for BitSet access can come first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
