uschindler commented on pull request #2616:
URL: https://github.com/apache/lucene-solr/pull/2616#issuecomment-977622289
I think the githib workflow needs to be removed in lucene-solr/master, too.
But that's plain simple separate commit. We may try it out if it still triggers
or not. I am a
uschindler commented on pull request #2616:
URL: https://github.com/apache/lucene-solr/pull/2616#issuecomment-977624155
On master branch is also a reference to branch_8x, should possibly also
removed. I can do this later when this is merged.
--
This is an automated message from the Apach
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448558#comment-17448558
]
Dawid Weiss commented on LUCENE-10255:
--
I tweaked the build so that the changes re
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448599#comment-17448599
]
Tomoko Uchida commented on LUCENE-10255:
{quote}I converted Luke to a full modu
rmuir opened a new pull request #471:
URL: https://github.com/apache/lucene/pull/471
These tests take between 15 and 30 seconds on my computer.
We have so many thousands of tests, we really shouldnt have individual tests
taking this long, it slows the whole process down.
This
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448599#comment-17448599
]
Tomoko Uchida edited comment on LUCENE-10255 at 11/24/21, 2:05 PM:
--
iverase commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756122609
##
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##
@@ -29,4 +31,18 @@
protected Codec getCo
rmuir commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756127628
##
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##
@@ -29,4 +31,18 @@
protected Codec getCode
rmuir commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756129050
##
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##
@@ -29,4 +31,18 @@
protected Codec getCode
Robert Muir created LUCENE-10257:
Summary: automation to help prevent slow tests from being added to
the codebase
Key: LUCENE-10257
URL: https://issues.apache.org/jira/browse/LUCENE-10257
Project: Luc
iverase commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756138598
##
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##
@@ -29,4 +31,18 @@
protected Codec getCo
iverase commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756148864
##
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##
@@ -29,4 +31,18 @@
protected Codec getCo
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448664#comment-17448664
]
Uwe Schindler commented on LUCENE-10255:
bq. It works but there is one side eff
[
https://issues.apache.org/jira/browse/LUCENE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller reassigned LUCENE-10258:
Assignee: Greg Miller
> DoubleValuesSource#fromScorer() should leverage ScoreCachingWrap
Greg Miller created LUCENE-10258:
Summary: DoubleValuesSource#fromScorer() should leverage
ScoreCachingWrappingScorer
Key: LUCENE-10258
URL: https://issues.apache.org/jira/browse/LUCENE-10258
Project:
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756167372
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756167372
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
rmuir commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756169341
##
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##
@@ -29,4 +31,18 @@
protected Codec getCode
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756167372
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756167372
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756173204
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
iverase commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756177223
##
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##
@@ -29,4 +31,18 @@
protected Codec getCo
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448670#comment-17448670
]
Tomoko Uchida commented on LUCENE-10255:
{quote}Generally Luke should support C
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448672#comment-17448672
]
Dawid Weiss commented on LUCENE-10255:
--
You can still run it in classpath mode, ri
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448675#comment-17448675
]
Uwe Schindler commented on LUCENE-10255:
bq. You can still run it in classpath
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756190306
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -35,7 +35,9 @@ allprojects {
// with a non-empty java.srcDirs. These tasks are then
// attache
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756192226
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756195400
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448681#comment-17448681
]
Dawid Weiss commented on LUCENE-10255:
--
You overestimate my experience with the mo
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756197015
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -35,7 +35,9 @@ allprojects {
// with a non-empty java.srcDirs. These tasks are then
// att
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756198498
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756203167
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756204497
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -35,7 +35,9 @@ allprojects {
// with a non-empty java.srcDirs. These tasks are then
// attache
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448689#comment-17448689
]
Uwe Schindler commented on LUCENE-10255:
It will see the SPIs if the module is
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448693#comment-17448693
]
Uwe Schindler commented on LUCENE-10255:
Oh I figured out, theoretically it sho
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448694#comment-17448694
]
Dawid Weiss commented on LUCENE-10255:
--
There is also require static, right? So th
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448693#comment-17448693
]
Uwe Schindler edited comment on LUCENE-10255 at 11/24/21, 3:49 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448695#comment-17448695
]
Tomoko Uchida commented on LUCENE-10255:
I mean - I'll try to follow core/infra
[
https://issues.apache.org/jira/browse/LUCENE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448696#comment-17448696
]
Greg Miller commented on LUCENE-10258:
--
Hmm, after writing some test cases (and ge
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448697#comment-17448697
]
Uwe Schindler commented on LUCENE-10255:
there's also "uses com.service.api.AnI
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448698#comment-17448698
]
Uwe Schindler commented on LUCENE-10255:
This looks like helpful:
https://www.
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448699#comment-17448699
]
Dawid Weiss commented on LUCENE-10255:
--
> As a fact, since 9.0 Luke's Analysis UI
jpountz merged pull request #2616:
URL: https://github.com/apache/lucene-solr/pull/2616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448702#comment-17448702
]
Uwe Schindler commented on LUCENE-10255:
As far as I see: lucene.core must also
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448704#comment-17448704
]
Dawid Weiss commented on LUCENE-10255:
--
> Let's go tep by step. We have to also ma
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448705#comment-17448705
]
Tomoko Uchida commented on LUCENE-10255:
{quote}There is still time to reiterat
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448708#comment-17448708
]
Dawid Weiss commented on LUCENE-10255:
--
No worries, Tomoko. Thank you for taking y
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448705#comment-17448705
]
Tomoko Uchida edited comment on LUCENE-10255 at 11/24/21, 4:12 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448711#comment-17448711
]
Tomoko Uchida commented on LUCENE-10255:
Please, no... I don't think there is n
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448711#comment-17448711
]
Tomoko Uchida edited comment on LUCENE-10255 at 11/24/21, 4:16 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10085.
---
Fix Version/s: 9.1
Resolution: Fixed
> Implement Weight#count on DocValuesFieldExist
uschindler commented on pull request #2616:
URL: https://github.com/apache/lucene-solr/pull/2616#issuecomment-978030726
I committed a6dcef49314a2651a5838c2b4ab2263aac69cd36 in master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uschindler edited a comment on pull request #2616:
URL: https://github.com/apache/lucene-solr/pull/2616#issuecomment-978030726
I committed a6dcef49314a2651a5838c2b4ab2263aac69cd36 and
860a9dbd42d1bfb021688bd40ded58d38dedaf8b in master.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448714#comment-17448714
]
Uwe Schindler commented on LUCENE-10255:
We won't have real modules in 9.0, so
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448717#comment-17448717
]
Uwe Schindler commented on LUCENE-10255:
If I have some time the next days I wi
[
https://issues.apache.org/jira/browse/LUCENE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448718#comment-17448718
]
Michael Sokolov commented on LUCENE-10258:
--
right, this is more an issue of ho
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448721#comment-17448721
]
Uwe Schindler commented on LUCENE-10255:
Yes we need to declare the SPI's we pr
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448721#comment-17448721
]
Uwe Schindler edited comment on LUCENE-10255 at 11/24/21, 4:42 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448726#comment-17448726
]
Adrien Grand commented on LUCENE-10235:
---
I agree that it is a bit unintuitive, bu
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448733#comment-17448733
]
Uwe Schindler commented on LUCENE-10255:
The rules are simple: Code that calls
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448741#comment-17448741
]
Adrien Grand commented on LUCENE-10255:
---
Tomoko, can you explain what is broken?
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756295802
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756295802
##
File path: lucene/core/src/java-module/module-info.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Uwe Schindler created LUCENE-10259:
--
Summary: Luke does not start with whitespace in unzipped directory.
Key: LUCENE-10259
URL: https://issues.apache.org/jira/browse/LUCENE-10259
Project: Lucene - Cor
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448751#comment-17448751
]
Uwe Schindler commented on LUCENE-10255:
[~jpountz], there are another Bug in L
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10259:
---
Priority: Blocker (was: Major)
> Luke does not start with whitespace in unzipped directory
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10259:
---
Affects Version/s: 9.0
> Luke does not start with whitespace in unzipped directory.
> -
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10259:
---
Component/s: luke
> Luke does not start with whitespace in unzipped directory.
> --
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10259:
---
Fix Version/s: 9.0
> Luke does not start with whitespace in unzipped directory.
> -
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10259:
---
Description:
When you start Luke on windows, nothing happens. No error message nothing. Thi
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448754#comment-17448754
]
Uwe Schindler commented on LUCENE-10255:
See LUCENE-10259
> Fully embrace the
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10255:
---
Attachment: screenshot-1.png
> Fully embrace the java module system
> -
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10255:
---
Attachment: screenshot-2.png
> Fully embrace the java module system
> -
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448755#comment-17448755
]
Uwe Schindler commented on LUCENE-10255:
The issue with Luke that Tomoko was re
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448755#comment-17448755
]
Uwe Schindler edited comment on LUCENE-10255 at 11/24/21, 5:52 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448756#comment-17448756
]
Uwe Schindler commented on LUCENE-10255:
(with full module system support as in
uschindler opened a new pull request #472:
URL: https://github.com/apache/lucene/pull/472
see https://issues.apache.org/jira/browse/LUCENE-10259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448761#comment-17448761
]
Uwe Schindler commented on LUCENE-10259:
See PR for fix: https://github.com/apa
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448763#comment-17448763
]
Uwe Schindler commented on LUCENE-10259:
It would be good if somebody could tes
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10259:
---
Attachment: screenshot-1.png
> Luke does not start with whitespace in unzipped directory.
>
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448765#comment-17448765
]
Uwe Schindler commented on LUCENE-10259:
OK, works on MacOS (before the line wi
Uwe Schindler created LUCENE-10260:
--
Summary: Luke's about window no longer shows version number
Key: LUCENE-10260
URL: https://issues.apache.org/jira/browse/LUCENE-10260
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448769#comment-17448769
]
Uwe Schindler commented on LUCENE-10259:
While testing I also found: LUCENE-102
[
https://issues.apache.org/jira/browse/LUCENE-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-10259:
--
Assignee: Uwe Schindler
> Luke does not start with whitespace in unzipped directory.
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448772#comment-17448772
]
Dawid Weiss commented on LUCENE-10255:
--
> you know most Windows users have whitesp
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448773#comment-17448773
]
Uwe Schindler edited comment on LUCENE-10255 at 11/24/21, 6:55 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448773#comment-17448773
]
Uwe Schindler commented on LUCENE-10255:
We don't need to revert module system
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448775#comment-17448775
]
Uwe Schindler commented on LUCENE-10255:
About the analyzers... I am thinking o
[
https://issues.apache.org/jira/browse/LUCENE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448786#comment-17448786
]
Dawid Weiss commented on LUCENE-10260:
--
I think we should get rid of the LucenePac
[
https://issues.apache.org/jira/browse/LUCENE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448788#comment-17448788
]
Uwe Schindler commented on LUCENE-10260:
This is caused by Module system: class
[
https://issues.apache.org/jira/browse/LUCENE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448790#comment-17448790
]
Dawid Weiss commented on LUCENE-10260:
--
> I tend to recommend to remove modules fr
[
https://issues.apache.org/jira/browse/LUCENE-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448791#comment-17448791
]
Dawid Weiss commented on LUCENE-10260:
--
Although the information from meta inf doe
Dawid Weiss created LUCENE-10261:
Summary: Preset/ custom analyzer pipelines in Luke won't work with
the module system
Key: LUCENE-10261
URL: https://issues.apache.org/jira/browse/LUCENE-10261
Project
uschindler commented on pull request #473:
URL: https://github.com/apache/lucene/pull/473#issuecomment-978176158
Looks fine, although I think the class LucenePackage should possibly go away
completely in 9.
We can add a getImplementationVersion to our standard Version class which
lo
uschindler edited a comment on pull request #473:
URL: https://github.com/apache/lucene/pull/473#issuecomment-978176158
Looks fine, although I think the class LucenePackage should possibly go away
completely in 9.
We can add a static getImplementationVersion to our standard Version c
dweiss commented on pull request #473:
URL: https://github.com/apache/lucene/pull/473#issuecomment-978177254
Sure, nuke or move anything you want - I just wanted to show that this works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
uschindler commented on a change in pull request #473:
URL: https://github.com/apache/lucene/pull/473#discussion_r756384830
##
File path: lucene/core/src/java/org/apache/lucene/LucenePackage.java
##
@@ -16,13 +16,53 @@
*/
package org.apache.lucene;
+import java.io.IOExcept
dweiss commented on a change in pull request #473:
URL: https://github.com/apache/lucene/pull/473#discussion_r756389521
##
File path: lucene/core/src/java/org/apache/lucene/LucenePackage.java
##
@@ -16,13 +16,53 @@
*/
package org.apache.lucene;
+import java.io.IOException;
dweiss commented on a change in pull request #473:
URL: https://github.com/apache/lucene/pull/473#discussion_r756389712
##
File path: lucene/core/src/java/org/apache/lucene/LucenePackage.java
##
@@ -16,13 +16,53 @@
*/
package org.apache.lucene;
+import java.io.IOException;
[
https://issues.apache.org/jira/browse/LUCENE-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448801#comment-17448801
]
Greg Miller commented on LUCENE-10258:
--
[~sokolov] yep, exactly. I poked around at
1 - 100 of 110 matches
Mail list logo
