dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r756204497
##########
File path: gradle/validation/ecj-lint.gradle
##########
@@ -35,7 +35,9 @@ allprojects {
// with a non-empty java.srcDirs. These tasks are then
// attached to project's "ecjLint" task.
def lintTasks = sourceSets.collect { sourceSet ->
- def srcDirs = sourceSet.java.srcDirs.findAll { dir -> dir.exists() }
+ def srcDirs = sourceSet.java.sourceDirectories
Review comment:
yup. one is java's set, the other is gradle's file collection - the
collection is live and needs no conversion, the api says it is preferred over
srcDirs so I used it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
