rmuir commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756127628
##########
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##########
@@ -29,4 +31,18 @@
protected Codec getCodec() {
return new SimpleTextCodec();
}
+
+ // TODO: can we speed up the underlying base test?
+ @Override
+ @LuceneTestCase.Nightly
Review comment:
Not true.
```
think:lucene[main]$ git grep LuceneTestCase.Nightly
lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestFactories.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestFactories.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestBlockPostingsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestBlockPostingsFormat2.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestBlockPostingsFormat3.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestForUtil.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestLucene50CompoundFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestLucene50LiveDocsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestLucene50StoredFieldsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestLucene50StoredFieldsFormatHighCompression.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestLucene50StoredFieldsFormatMergeInstance.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestLucene50TermVectorsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene60/TestLucene60FieldInfosFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene60/TestLucene60PointsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene70/TestLucene70SegmentInfoFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene80/TestBestCompressionLucene80DocValuesFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene80/TestBestSpeedLucene80DocValuesFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene80/TestDocValuesCompression.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene80/TestIndexedDISI.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene80/TestLucene80NormsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene80/TestLucene80NormsFormatMergeInstance.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene84/TestForDeltaUtil.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene84/TestForUtil.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene84/TestLucene84PostingsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene84/TestPForUtil.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene86/TestLucene86PointsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene86/TestLucene86SegmentInfoFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene87/TestLucene87StoredFieldsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene87/TestLucene87StoredFieldsFormatHighCompression.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene87/TestLucene87StoredFieldsFormatMergeInstance.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/packed/TestLegacyDirectMonotonic.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/packed/TestLegacyDirectPacked.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/packed/TestLegacyPackedInts.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/store/EndiannessReverserTestCase.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/store/TestEndiannessReverserCheckSumIndexInput.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/store/TestEndiannessReverserIndexInput.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextPostingsFormat.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/core/src/test/org/apache/lucene/index/TestDuelingCodecsAtNight.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
lucene/core/src/test/org/apache/lucene/util/TestTimSorterWorstCase.java:import
org.apache.lucene.util.LuceneTestCase.Nightly;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
