uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r756295802
########## File path: lucene/core/src/java-module/module-info.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/** Lucene Core. */ +module lucene.core { + exports org.apache.lucene; + exports org.apache.lucene.analysis; + exports org.apache.lucene.analysis.standard; + exports org.apache.lucene.analysis.tokenattributes; + exports org.apache.lucene.codecs; + exports org.apache.lucene.codecs.compressing; + exports org.apache.lucene.codecs.lucene90; + exports org.apache.lucene.codecs.lucene90.blocktree; + exports org.apache.lucene.codecs.lucene90.compressing; + exports org.apache.lucene.codecs.perfield; + exports org.apache.lucene.document; + exports org.apache.lucene.geo; + exports org.apache.lucene.index; + exports org.apache.lucene.search; + exports org.apache.lucene.search.comparators; + exports org.apache.lucene.search.similarities; + exports org.apache.lucene.store; + exports org.apache.lucene.util; + exports org.apache.lucene.util.automaton; + exports org.apache.lucene.util.bkd; + exports org.apache.lucene.util.compress; + exports org.apache.lucene.util.fst; + exports org.apache.lucene.util.graph; + exports org.apache.lucene.util.hnsw; + exports org.apache.lucene.util.hppc; + exports org.apache.lucene.util.mutable; + exports org.apache.lucene.util.packed; + + provides org.apache.lucene.analysis.TokenizerFactory with Review comment: See related issue: We must also add a `uses Codec` and `uses TokenizerFactory` for all possible SPI classes we have. `provides` makes it discoverable to outside modules, but because we also consume the implementations of those classes outside of Lucene's core module, we must make a uses statement for all SPIs which are cosumed by us (codecs, analyzer components, sort fields,...). Grep for `ServiceLoader` in ource code and check with which classes it is called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
