rmuir commented on a change in pull request #471:
URL: https://github.com/apache/lucene/pull/471#discussion_r756169341
##########
File path:
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextTermVectorsFormat.java
##########
@@ -29,4 +31,18 @@
protected Codec getCodec() {
return new SimpleTextCodec();
}
+
+ // TODO: can we speed up the underlying base test?
+ @Override
+ @LuceneTestCase.Nightly
Review comment:
I don't think it matters really. In general annotations are applied both
ways:
```
think:lucene[main]$ git grep '@LuceneTestCase.'
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java:
@LuceneTestCase.AwaitsFix(bugUrl = "Unavailable until 9.0.0 is released")
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java:
@LuceneTestCase.AwaitsFix(bugUrl = "Unavailable until 9.0.0 is released")
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java:
@LuceneTestCase.AwaitsFix(bugUrl = "Unavailable until 9.0.0 is released")
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java:
@LuceneTestCase.AwaitsFix(bugUrl = "Unavailable until 9.0.0 is released")
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java:
@LuceneTestCase.AwaitsFix(bugUrl = "Unavailable until 9.0.0 is released")
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java:
@LuceneTestCase.AwaitsFix(bugUrl = "Unavailable until 9.0.0 is released")
lucene/benchmark/src/test/org/apache/lucene/benchmark/byTask/TestPerfTasksLogic.java:@LuceneTestCase.SuppressCodecs({"SimpleText",
"Direct"})
lucene/classification/src/test/org/apache/lucene/classification/Test20NewsgroupsClassification.java:@LuceneTestCase.SuppressSysoutChecks(bugUrl
= "none")
lucene/classification/src/test/org/apache/lucene/classification/Test20NewsgroupsClassification.java:@LuceneTestCase.Monster("takes
a lot!")
lucene/classification/src/test/org/apache/lucene/classification/utils/TestDataSplitter.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/codecs/perfield/TestPerFieldPostingsFormat2.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/document/TestXYMultiPolygonShapeQueries.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/index/TestDirectoryReader.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMergePolicy.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterThreadsToSegments.java:@LuceneTestCase.SuppressCodecs({"SimpleText",
"Direct"})
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterWithThreads.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/index/TestManyFields.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/search/TestDisjunctionMaxQuery.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/search/TestDoubleValuesSource.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/search/TestPointQueries.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/core/src/test/org/apache/lucene/store/TestStressLockFactories.java:@LuceneTestCase.SuppressFileSystems("*")
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestSearcherTaxonomyManager.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAddTaxonomy.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/luke/src/test/org/apache/lucene/luke/models/documents/TestDocumentsImpl.java:@LuceneTestCase.SuppressCodecs({
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java:@LuceneTestCase.SuppressCodecs("SimpleText")
lucene/spatial-extras/src/test/org/apache/lucene/spatial/prefix/TestRecursivePrefixTreeStrategy.java:@LuceneTestCase.SuppressCodecs("SimpleText")
```
But if it bothers you, feel free to push to this branch (i'm about to leave
for holiday with no computer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
