[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524950844 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -p

[jira] [Created] (LUCENE-9612) TestBestCompressionLucene80DocValuesFormat fails reliably with java.io.FileNotFoundException: _0_Lucene80_0.dvm

2020-11-17 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9612: --- Summary: TestBestCompressionLucene80DocValuesFormat fails reliably with java.io.FileNotFoundException: _0_Lucene80_0.dvm Key: LUCENE-9612 URL: https://issues.apache.org/jira/browse/

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524958131 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -publi

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524954118 ## File path: lucene/misc/src/java/overview.html ## @@ -35,7 +35,7 @@ NativeUnixDirectory have to compile on your platform. -{@link org.apache

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524961331 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/DirectIODirectoryTest.java ## @@ -18,29 +18,37 @@ import com.carrotsearch.randomize

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524961831 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -p

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524962771 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524963604 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -p

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524965464 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/DirectIODirectoryTest.java ## @@ -18,29 +18,37 @@ import com.carrotsearch.rando

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524967715 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -p

[GitHub] [lucene-solr] mocobeta merged pull request #2081: LUCENE-9413: Add CJKWidthCharFilter and its factory.

2020-11-17 Thread GitBox
mocobeta merged pull request #2081: URL: https://github.com/apache/lucene-solr/pull/2081 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] mocobeta commented on pull request #2081: LUCENE-9413: Add CJKWidthCharFilter and its factory.

2020-11-17 Thread GitBox
mocobeta commented on pull request #2081: URL: https://github.com/apache/lucene-solr/pull/2081#issuecomment-728773010 Merged. Thank you @rmuir for review! This is an automated message from the Apache Git Service. To respond t

[jira] [Commented] (LUCENE-9413) Add a char filter corresponding to CJKWidthFilter

2020-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233441#comment-17233441 ] ASF subversion and git services commented on LUCENE-9413: - Commi

[GitHub] [lucene-solr] uschindler commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-728774023 Hi, We can also remove WindowsDirectory. This one was not done for direct IO, bt it's obsolete, too: https://issues.apache.org/jira/browse/LUCENE-2791 It was mad

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524972056 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -publi

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-728774023 Hi, We can also remove WindowsDirectory. This one was not done for direct IO, but in my opinion, it's obsolete, too: https://issues.apache.org/jira/browse/LUCEN

[jira] [Commented] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233445#comment-17233445 ] ASF subversion and git services commented on LUCENE-9378: - Commi

[jira] [Resolved] (LUCENE-9612) TestBestCompressionLucene80DocValuesFormat fails reliably with java.io.FileNotFoundException: _0_Lucene80_0.dvm

2020-11-17 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9612. -- Resolution: Fixed Woops, I thought I had fixed it over the weekend but my push only worked on

[jira] [Commented] (LUCENE-9612) TestBestCompressionLucene80DocValuesFormat fails reliably with java.io.FileNotFoundException: _0_Lucene80_0.dvm

2020-11-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233452#comment-17233452 ] Dawid Weiss commented on LUCENE-9612: - Ah, thanks for looking into it, Adrien! > Te

[GitHub] [lucene-solr] janhoy commented on pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-11-17 Thread GitBox
janhoy commented on pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-728787567 +1 to lighter weight. However, our users should somehow be able to verify that a Docker image pulled from Docker Hub (or downloaded from elsewhere) is indeed the officially v

[jira] [Commented] (LUCENE-9413) Add a char filter corresponding to CJKWidthFilter

2020-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233487#comment-17233487 ] ASF subversion and git services commented on LUCENE-9413: - Commi

[jira] [Commented] (LUCENE-9413) Add a char filter corresponding to CJKWidthFilter

2020-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233486#comment-17233486 ] ASF subversion and git services commented on LUCENE-9413: - Commi

[jira] [Resolved] (LUCENE-9413) Add a char filter corresponding to CJKWidthFilter

2020-11-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-9413. --- Fix Version/s: 8.8 Assignee: Tomoko Uchida Resolution: Fixed > Add a char fi

[jira] [Updated] (LUCENE-9413) Add a char filter corresponding to CJKWidthFilter

2020-11-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9413: -- Fix Version/s: master (9.0) > Add a char filter corresponding to CJKWidthFilter >

[GitHub] [lucene-solr] msokolov merged pull request #2053: LUCENE-8626: Standardize Lucene Test Files Part 2

2020-11-17 Thread GitBox
msokolov merged pull request #2053: URL: https://github.com/apache/lucene-solr/pull/2053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233574#comment-17233574 ] ASF subversion and git services commented on LUCENE-8626: - Commi

[jira] [Commented] (LUCENE-9004) Approximate nearest vector search

2020-11-17 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233633#comment-17233633 ] Michael Sokolov commented on LUCENE-9004: - I changed it to . Based on https://d

[jira] [Created] (LUCENE-9613) Create blocks for ords when it helps in Lucene80DocValuesFormat

2020-11-17 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-9613: Summary: Create blocks for ords when it helps in Lucene80DocValuesFormat Key: LUCENE-9613 URL: https://issues.apache.org/jira/browse/LUCENE-9613 Project: Lucene - Cor

[jira] [Resolved] (LUCENE-9023) GlobalOrdinalsWithScore should not compute occurrences when the provided min is 1

2020-11-17 Thread Jim Ferenczi (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Ferenczi resolved LUCENE-9023. -- Fix Version/s: 8.8 Resolution: Fixed > GlobalOrdinalsWithScore should not compute occur

[jira] [Commented] (SOLR-14608) Faster sorting for the /export handler

2020-11-17 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233638#comment-17233638 ] Joel Bernstein commented on SOLR-14608: --- Coming back to this ticket to get it wrapp

[jira] [Comment Edited] (SOLR-14608) Faster sorting for the /export handler

2020-11-17 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233638#comment-17233638 ] Joel Bernstein edited comment on SOLR-14608 at 11/17/20, 2:49 PM: -

[jira] [Comment Edited] (SOLR-14608) Faster sorting for the /export handler

2020-11-17 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233638#comment-17233638 ] Joel Bernstein edited comment on SOLR-14608 at 11/17/20, 2:48 PM: -

[GitHub] [lucene-solr] mikemccand commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
mikemccand commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729002846 > IMHO, we should add more Javadocs, that this directory may throw UnsupportedOperationException if the underlying platform does not allow direct IO. Hmm, maybe th

[GitHub] [lucene-solr] mikemccand commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
mikemccand commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729007347 > > Thank you @zacharymorn! It's so nice we can move this to pure java now -- this makes it much easier and lower risk for Lucene users to test. > > I suspect for Lucen

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
mikemccand commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525257315 ## File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp ## @@ -102,6 +102,7 @@ JNIEXPORT jint JNICALL Java_org_apache_lucene_misc_stor

[jira] [Commented] (SOLR-14973) Solr 8.6 is shipping libraries that are incompatible with each other

2020-11-17 Thread Markus Schuch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233680#comment-17233680 ] Markus Schuch commented on SOLR-14973: -- I think this is fixed in Solr 8.7.0 by SOLR-

[jira] [Commented] (SOLR-14973) Solr 8.6 is shipping libraries that are incompatible with each other

2020-11-17 Thread Tim Allison (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233697#comment-17233697 ] Tim Allison commented on SOLR-14973: Y. I believe that it is fixed in 8.7.0, too. It

[GitHub] [lucene-solr] uschindler commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729034044 > Hmm, maybe this is a good reason to make this change in two steps (add pure java version, then, later, remove native one)? Which platforms will now throw UnsupportedOpe

[GitHub] [lucene-solr] uschindler commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729037126 > Second, it is extremely experimental and not clear when it provides benefits / what risks there are / etc. We need to learn much more about it, in diverse usage, to hel

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729037126 > Second, it is extremely experimental and not clear when it provides benefits / what risks there are / etc. We need to learn much more about it, in diverse usage,

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525294149 ## File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp ## @@ -102,6 +102,7 @@ JNIEXPORT jint JNICALL Java_org_apache_lucene_misc_stor

[GitHub] [lucene-solr] uschindler commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729039812 > I think we just need to resolve the "replace now or not" question? I'd like to improve the testcase and use a real index on top of a combination with FSDirectory.

[jira] [Created] (LUCENE-9614) Implement KNN Query

2020-11-17 Thread Michael Sokolov (Jira)
Michael Sokolov created LUCENE-9614: --- Summary: Implement KNN Query Key: LUCENE-9614 URL: https://issues.apache.org/jira/browse/LUCENE-9614 Project: Lucene - Core Issue Type: New Feature

[jira] [Created] (LUCENE-9615) Expose HnswGraphBuilder index-time hyperparameters

2020-11-17 Thread Michael Sokolov (Jira)
Michael Sokolov created LUCENE-9615: --- Summary: Expose HnswGraphBuilder index-time hyperparameters Key: LUCENE-9615 URL: https://issues.apache.org/jira/browse/LUCENE-9615 Project: Lucene - Core

[jira] [Updated] (LUCENE-9615) Expose HnswGraphBuilder index-time hyperparameters

2020-11-17 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov updated LUCENE-9615: Description: HnswGraphBuilder has a few tunables: fanout, beamWidth, potentially whether t

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525305942 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -p

[GitHub] [lucene-solr] uschindler commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729050496 Another thing to keep in mind: The old/new direct i/o dircetory has one problem: It uses ByteBuffer.allocateDirect on every clone. As the garbage collector needs to clean

[jira] [Updated] (LUCENE-9615) Expose HnswGraphBuilder index-time hyperparameters

2020-11-17 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov updated LUCENE-9615: Description: HnswGraphBuilder has a few tunables: maxConnections, beamWidth, and we may ad

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729050496 Another thing to keep in mind: The old/new direct i/o dircetory has one problem: It uses ByteBuffer.allocateDirect on every clone. As the garbage collector needs t

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
uschindler edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729050496 Another thing to keep in mind: The old/new direct i/o dircetory has one problem: It uses ByteBuffer.allocateDirect on every clone. As the garbage collector needs t

[GitHub] [lucene-solr] alessandrobenedetti commented on pull request #1571: SOLR-14560: Interleaving for Learning To Rank

2020-11-17 Thread GitBox
alessandrobenedetti commented on pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#issuecomment-729051840 I am not against the back-compat niceties, but is there any automatic tool that will remove them when a release candidate happen for 9.0 ? If not I suspect we

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-11-17 Thread GitBox
HoustonPutman commented on pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-729061623 I completely agree with everything you've said @janhoy, and really like that solution! I am by no means an expert on this verification stuff, so what do you imagine `v

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2067: SOLR-14987: Reuse HttpSolrClient per node vs. one per Solr core when using CloudSolrStream

2020-11-17 Thread GitBox
thelabdude commented on a change in pull request #2067: URL: https://github.com/apache/lucene-solr/pull/2067#discussion_r525335246 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java ## @@ -334,11 +334,6 @@ private StreamComparator par

[jira] [Created] (SOLR-15007) Aggregate core handler=/select and /update metrics at the node level metric too

2020-11-17 Thread Mathieu Marie (Jira)
Mathieu Marie created SOLR-15007: Summary: Aggregate core handler=/select and /update metrics at the node level metric too Key: SOLR-15007 URL: https://issues.apache.org/jira/browse/SOLR-15007 Project

[jira] [Commented] (SOLR-15007) Aggregate core handler=/select and /update metrics at the node level metric too

2020-11-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233760#comment-17233760 ] David Smiley commented on SOLR-15007: - I am thinking of a rough idea of an implementa

[GitHub] [lucene-solr] cpoerschke commented on pull request #1571: SOLR-14560: Interleaving for Learning To Rank

2020-11-17 Thread GitBox
cpoerschke commented on pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#issuecomment-729102552 > ... is there any automatic tool that will remove them ... If not I suspect we may risk forgetting ... I'm not aware of any automatic tool we currently use that wo

[jira] [Commented] (SOLR-14683) Review the metrics API to ensure consistent placeholders for missing values

2020-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233792#comment-17233792 ] ASF subversion and git services commented on SOLR-14683: Commit 2

[jira] [Commented] (SOLR-14683) Review the metrics API to ensure consistent placeholders for missing values

2020-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233793#comment-17233793 ] ASF subversion and git services commented on SOLR-14683: Commit 1

[GitHub] [lucene-solr] jtibshirani commented on pull request #2084: LUCENE-9592: Loosen equality checks in TestVectorUtil.

2020-11-17 Thread GitBox
jtibshirani commented on pull request #2084: URL: https://github.com/apache/lucene-solr/pull/2084#issuecomment-729105823 > Are you able to push the commit yet? Not yet, I'm still waiting on account credentials. This is

[GitHub] [lucene-solr] jtibshirani closed pull request #2047: LUCENE-9592: Use doubles in VectorUtil to maintain precision.

2020-11-17 Thread GitBox
jtibshirani closed pull request #2047: URL: https://github.com/apache/lucene-solr/pull/2047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2047: LUCENE-9592: Use doubles in VectorUtil to maintain precision.

2020-11-17 Thread GitBox
jtibshirani commented on a change in pull request #2047: URL: https://github.com/apache/lucene-solr/pull/2047#discussion_r524835397 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -25,47 +25,22 @@ private VectorUtil() { } - public static

[jira] [Commented] (SOLR-14921) terms filter in json.facet

2020-11-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233806#comment-17233806 ] Jason Gerlowski commented on SOLR-14921: I'll qualify my comments below by admitt

[jira] [Commented] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-11-17 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233826#comment-17233826 ] Gautam Worah commented on LUCENE-9378: -- Thanks for catching that regression so quic

[jira] [Comment Edited] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-11-17 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233826#comment-17233826 ] Gautam Worah edited comment on LUCENE-9378 at 11/17/20, 6:49 PM: -

[jira] [Commented] (LUCENE-9004) Approximate nearest vector search

2020-11-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233865#comment-17233865 ] Uwe Schindler commented on LUCENE-9004: --- {quote}I changed it to . Based on [https

[jira] [Comment Edited] (LUCENE-9004) Approximate nearest vector search

2020-11-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233865#comment-17233865 ] Uwe Schindler edited comment on LUCENE-9004 at 11/17/20, 7:18 PM:

[jira] [Commented] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-11-17 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233885#comment-17233885 ] Michael McCandless commented on LUCENE-9378: {quote}Meanwhile, I'll open an

[jira] [Commented] (LUCENE-9004) Approximate nearest vector search

2020-11-17 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233906#comment-17233906 ] Michael Sokolov commented on LUCENE-9004: - Oh excellent, I stand corrected, than

[GitHub] [lucene-solr] dsmiley commented on pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-11-17 Thread GitBox
dsmiley commented on pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-729210262 Wouldn't it be simpler for the release manager to build the docker image, examine the sha256 hash of the image, and publish that to the download location, making it official

[jira] [Commented] (SOLR-14792) Remove VelocityResponseWriter from Solr 9

2020-11-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233976#comment-17233976 ] ASF subversion and git services commented on SOLR-14792: Commit e

[jira] [Commented] (SOLR-14921) terms filter in json.facet

2020-11-17 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234003#comment-17234003 ] Michael Gibney commented on SOLR-14921: --- Thanks for taking a look, [~gerlowskija]!

[jira] [Updated] (LUCENE-9616) Improve test coverage for internal format versions

2020-11-17 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9616: - Description: Some formats use an internal versioning system -- for example {{Compressin

[jira] [Created] (LUCENE-9616) Improve test coverage for internal format versions

2020-11-17 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9616: Summary: Improve test coverage for internal format versions Key: LUCENE-9616 URL: https://issues.apache.org/jira/browse/LUCENE-9616 Project: Lucene - Core

[GitHub] [lucene-solr] rustamhsmv closed pull request #125: SOLR-9868 RangeFacet : Use DocValues for accs and docSet collection instead of RangeQuery

2020-11-17 Thread GitBox
rustamhsmv closed pull request #125: URL: https://github.com/apache/lucene-solr/pull/125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] rustamhsmv closed pull request #126: SOLR-9876 Reuse CountSlotArrAcc internal array for same level subFacets

2020-11-17 Thread GitBox
rustamhsmv closed pull request #126: URL: https://github.com/apache/lucene-solr/pull/126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Comment Edited] (LUCENE-9378) Configurable compression for BinaryDocValues

2020-11-17 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233826#comment-17233826 ] Gautam Worah edited comment on LUCENE-9378 at 11/18/20, 12:11 AM:

[GitHub] [lucene-solr] dxl360 commented on pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-11-17 Thread GitBox
dxl360 commented on pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-729332268 > I'm concerned about this change: other things will overflow if you have too many term frequencies in a field. Currently frequency is bounded by 2^32-1 within a doc, and you

[GitHub] [lucene-solr] dxl360 closed pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-11-17 Thread GitBox
dxl360 closed pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dxl360 removed a comment on pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-11-17 Thread GitBox
dxl360 removed a comment on pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-729332268 > I'm concerned about this change: other things will overflow if you have too many term frequencies in a field. Currently frequency is bounded by 2^32-1 within a doc,

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525746628 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */ -

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525747082 ## File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp ## @@ -102,6 +102,7 @@ JNIEXPORT jint JNICALL Java_org_apache_lucene_misc_sto

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525747419 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/DirectIODirectoryTest.java ## @@ -18,29 +18,37 @@ import com.carrotsearch.rand

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729387261 > > Second, it is extremely experimental and not clear when it provides benefits / what risks there are / etc. We need to learn much more about it, in diverse usage, to

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525759421 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729389857 > > I think we just need to resolve the "replace now or not" question? > > I'd like to improve the testcase and use a real index on top of a combination with FSDir

[GitHub] [lucene-solr] zacharymorn edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729389857 > > I think we just need to resolve the "replace now or not" question? > > I'd like to improve the testcase and use a real index on top of a combination wit

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-11-17 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729393685 I've been following the comment thread on `WindowsDirectory`, but not sure if there's a consensus to remove it in this PR? For the time being, I've pushed a standalone c

[GitHub] [lucene-solr] anshumg commented on a change in pull request #2010: SOLR-12182: Don't persist base_url in ZK as the scheme is variable, compute from node_name instead

2020-11-17 Thread GitBox
anshumg commented on a change in pull request #2010: URL: https://github.com/apache/lucene-solr/pull/2010#discussion_r525809933 ## File path: solr/core/src/test/org/apache/solr/cloud/LeaderElectionTest.java ## @@ -414,6 +425,11 @@ private void waitForLeader(List threads, int s

[GitHub] [lucene-solr] dxl360 commented on pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-11-17 Thread GitBox
dxl360 commented on pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-729475817 Original implementation accumulates `int invertState.length` (number of tokens) by term frequency and will overflow if the term frequency is too large. Can we increment `leng