dweiss commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524961331
##########
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/DirectIODirectoryTest.java
##########
@@ -18,29 +18,37 @@
import com.carrotsearch.randomizedtesting.LifecycleScope;
import com.carrotsearch.randomizedtesting.RandomizedTest;
-import org.apache.lucene.store.ByteBuffersDirectory;
-import org.apache.lucene.store.Directory;
-import org.apache.lucene.store.IOContext;
-import org.apache.lucene.store.MergeInfo;
+import org.apache.lucene.store.*;
import org.apache.lucene.util.LuceneTestCase;
-import org.junit.Rule;
-import org.junit.rules.TestRule;
import java.io.IOException;
-import java.util.EnumSet;
+import java.nio.file.Files;
-public class NativeUnixDirectoryTest extends LuceneTestCase {
- @Rule
- public static TestRule requiresNative = new NativeLibEnableRule(
- EnumSet.of(NativeLibEnableRule.OperatingSystem.MAC,
- NativeLibEnableRule.OperatingSystem.FREE_BSD,
- NativeLibEnableRule.OperatingSystem.LINUX));
+import static
org.apache.lucene.misc.store.DirectIODirectory.DEFAULT_MIN_BYTES_DIRECT;
- public void testLibraryLoaded() throws IOException {
+public class DirectIODirectoryTest extends LuceneTestCase {
Review comment:
The native version worked for me. I agree with extending base directory
test case - I just showed an example of how to make the test run across
platforms, even if it required a native dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
