uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524950844
##########
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##########
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
-public class NativeUnixDirectory extends FSDirectory {
Review comment:
I don't think any explicit perf testing is needed, as we just replace
the calls to our CPP file by setting the flag on open of FileChannel.
It's good that I have seen this pull request, because I was wondering why we
took the "make native builds available" at all.
We should also remove WindowsDirectory, because this one also works on
Windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
