uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524961831
##########
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##########
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
-public class NativeUnixDirectory extends FSDirectory {
Review comment:
I am not fully sure if the ExtendedOpenOption works at all with Windows.
When checking the OpenJDK sources it seems to throw UOE, but haven't tested
with new JDKs yet.
Anyways, we should try to get rid of WindowsDirectory, too, as the intention
behind it is the same: do direct IO, it's just named differently on Windows.
We should maybe also look into the other ExtendedOpenptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
