zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525746628
##########
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##########
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
-public class NativeUnixDirectory extends FSDirectory {
Review comment:
> IMHO, we should add more Javadocs, that this directory may throw
UnsupportedOperationException if the underlying platform does not allow direct
IO.
Ops yes I saw saw as well, but forgot to add earlier. Just added more java
docs in latest commit.
> No worries, Zach. I think that native build part was a fun exercise! Code
comes and goes, it's normal. Sleep well.
Haha thanks Dawid! I've learnt a great deal from that exercise as well!
> On Windows, currently you can only use MMapDirectory in a highly
concurrent environment, because of the locking problem with positional reads in
FileChannel.
I would like to learn more about this issue but can't seems to find in java
doc for `ExtendedOpenOption.DIRECT`. Is this the one you are referring to:
1.
https://lucene.apache.org/core/8_1_1/core/org/apache/lucene/store/FSDirectory.html
"Unfortunately, due to a Windows-only Sun JRE bug this is a poor choice for
Windows, but on all other platforms this is the preferred choice."
2. https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6265734
##########
File path: lucene/misc/src/java/overview.html
##########
@@ -35,7 +35,7 @@ <h2>NativeUnixDirectory</h2>
have to compile on your platform.
<p>
-{@link org.apache.lucene.misc.store.NativeUnixDirectory} is a Directory
implementation that bypasses the
+{@link org.apache.lucene.misc.store.DirectIODirectory} is a Directory
implementation that bypasses the
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
