dweiss commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r498666282
##
File path: lucene/packaging/build.gradle
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contrib
dweiss commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r498666120
##
File path: lucene/packaging/build.gradle
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contrib
[
https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206088#comment-17206088
]
Jim Ferenczi commented on LUCENE-9004:
--
> I think this is not so for the NSW algori
iverase opened a new pull request #1939:
URL: https://github.com/apache/lucene-solr/pull/1939
New query that accepts an array of XYGeometries.
This is an automated message from the Apache Git Service.
To respond to the messa
Erick Erickson created SOLR-14910:
-
Summary: Use in-line tags for logger declarations in Gradle
ValidateLogCalls that are non-standard
Key: SOLR-14910
URL: https://issues.apache.org/jira/browse/SOLR-14910
[
https://issues.apache.org/jira/browse/SOLR-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206151#comment-17206151
]
Erick Erickson commented on SOLR-14910:
---
[~dsmiley] pointed out that having to muck
[
https://issues.apache.org/jira/browse/SOLR-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14910:
--
Summary: Use in-line tags for logger declarations in Gradle
ValidateLogCalls that are non-stand
dsmiley commented on a change in pull request #1921:
URL: https://github.com/apache/lucene-solr/pull/1921#discussion_r498832396
##
File path: solr/solr-ref-guide/src/common-query-parameters.adoc
##
@@ -307,11 +307,13 @@ The `echoParams` parameter controls what information
abou
iverase opened a new pull request #1940:
URL: https://github.com/apache/lucene-solr/pull/1940
New query that accepts an array of LatLonGeometries.
This is an automated message from the Apache Git Service.
To respond to th
mayya-sharipova commented on a change in pull request #1937:
URL: https://github.com/apache/lucene-solr/pull/1937#discussion_r498851410
##
File path: lucene/core/src/java/org/apache/lucene/search/ConjunctionDISI.java
##
@@ -140,6 +141,13 @@ private static void addTwoPhaseIterat
[
https://issues.apache.org/jira/browse/SOLR-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson reassigned SOLR-14910:
-
Assignee: Erick Erickson
> Use in-line tags for logger declarations in Gradle ValidateLo
Nhat Nguyen created LUCENE-9554:
---
Summary: Expose pendingNumDocs from IndexWriter
Key: LUCENE-9554
URL: https://issues.apache.org/jira/browse/LUCENE-9554
Project: Lucene - Core
Issue Type: Impr
cpoerschke merged pull request #1920:
URL: https://github.com/apache/lucene-solr/pull/1920
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dnhatn opened a new pull request #1941:
URL: https://github.com/apache/lucene-solr/pull/1941
Some applications can use the pendingNumDocs from IndexWriter to estimate
that the number of documents of an index is very close to the hard limit so
that it can reject writes without constructing
cpoerschke commented on pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890#issuecomment-702776305
> ... if adding of `ConfigSetsAPITest` functionality to `TestConfigSetsAPI`
might be better? ...
Looking more closely, there seem to be sufficient differences betwe
rmuir commented on pull request #1940:
URL: https://github.com/apache/lucene-solr/pull/1940#issuecomment-702790376
Why is this needed when the existing Polygon is a multipolygon and optimizes
for that case? Instead of making an array of polygons, just use a single
MultiPolygon?
-
ErickErickson opened a new pull request #1942:
URL: https://github.com/apache/lucene-solr/pull/1942
Most of this is just changing //logok to //nowarn.
The substantive changes are in validate-log-calls.gradle, taking out the
special handling for several files and _not_ producing fail
dsmiley commented on a change in pull request #1942:
URL: https://github.com/apache/lucene-solr/pull/1942#discussion_r498887554
##
File path: solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java
##
@@ -493,7 +493,7 @@ Action authorize() throws IOException {
}
mikemccand commented on a change in pull request #1941:
URL: https://github.com/apache/lucene-solr/pull/1941#discussion_r498907778
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -1072,7 +1073,14 @@ public IndexWriter(Directory d, IndexWriterCo
iverase commented on pull request #1940:
URL: https://github.com/apache/lucene-solr/pull/1940#issuecomment-702819188
I have two motivations for this change:
1) Finding all points at a distance of a line can be approximated by
creating a polygon and two circles and finding all points
thelabdude commented on pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#issuecomment-702821500
Thanks @noblepaul ... that's much cleaner. Patch applied.
This is an automated message from the Apache Gi
thelabdude commented on a change in pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#discussion_r498916106
##
File path: solr/core/src/java/org/apache/solr/rest/RestManager.java
##
@@ -326,44 +327,46 @@ public void doInit() throws ResourceException {
Mayya Sharipova created LUCENE-9555:
---
Summary: Sort optimization failure if scorerIterator is already
advanced
Key: LUCENE-9555
URL: https://issues.apache.org/jira/browse/LUCENE-9555
Project: Lucene
ErickErickson commented on pull request #1942:
URL: https://github.com/apache/lucene-solr/pull/1942#issuecomment-702826141
It was decided (there’s a phrase I hate, used to avoid taking responsibility
for something)…
Anyway, Andras Salamon and I decided that it was often an error to h
mikemccand commented on a change in pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#discussion_r498242843
##
File path:
lucene/core/src/java/org/apache/lucene/index/ApproximatePriorityQueue.java
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Softw
[
https://issues.apache.org/jira/browse/LUCENE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova updated LUCENE-9555:
Description:
Some collectors provide iterators that can efficiently skip non-competitive
[
https://issues.apache.org/jira/browse/LUCENE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova updated LUCENE-9555:
Description:
Some collectors provide iterators that can efficiently skip non-competitive
mayya-sharipova opened a new pull request #1943:
URL: https://github.com/apache/lucene-solr/pull/1943
Some collectors provide iterators that can efficiently skip
non-competitive docs. When using DefaultBulkScorer#score function
we create a conjunction of scorerIterator and collectorIte
[
https://issues.apache.org/jira/browse/SOLR-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter updated SOLR-14659:
--
Fix Version/s: (was: 8.7)
master (9.0)
> Remove restlet from Solr
>
[
https://issues.apache.org/jira/browse/SOLR-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter reassigned SOLR-14659:
-
Assignee: Timothy Potter
> Remove restlet from Solr
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206313#comment-17206313
]
Timothy Potter commented on SOLR-14659:
---
I'm changing the fix version to 9.0 for th
mayya-sharipova commented on pull request #1943:
URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-702831820
This patch also addresses the failure of
`TestUnifiedHighlighterStrictPhrases.testBasics`.
This test was using `ReqExclBulkScorer` that lead to `scorerIterator` be
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206314#comment-17206314
]
Michael McCandless commented on LUCENE-9444:
[~goankur] can we re-resolve th
thelabdude commented on pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#issuecomment-702832996
@noblepaul so you had SOLR-14659 with fix version 8.7. Given all the tests
pass, I think we could apply these changes for 8.7 but I'd be more comfortable
if we just left
[
https://issues.apache.org/jira/browse/LUCENE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206317#comment-17206317
]
Michael McCandless commented on LUCENE-4510:
Thanks [~dweiss], [~rcmuir] and
dnhatn commented on pull request #1941:
URL: https://github.com/apache/lucene-solr/pull/1941#issuecomment-702837408
> I was a little confused by why we separate negative and non-negative cases
in IndexWriter...
@mikemccand Thank you for looking. I reverted that change and will make
mikemccand commented on a change in pull request #1941:
URL: https://github.com/apache/lucene-solr/pull/1941#discussion_r498937003
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -5463,6 +5463,13 @@ private void tooManyDocs(long addedNumDocs) {
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r498948018
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##
@@ -146,93 +149,114 @@ public LTRQParser(String qstr,
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206361#comment-17206361
]
Andrzej Bialecki commented on SOLR-14749:
-
{quote}The PR is too complex.
{quote}
murblanc commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r498954021
##
File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterEvent.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundat
muse-dev[bot] commented on a change in pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#discussion_r498956758
##
File path: solr/core/src/java/org/apache/solr/rest/RestManager.java
##
@@ -160,6 +156,10 @@ private Pattern getReservedEndpointsPattern() {
murblanc commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r498957288
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/ClusterEventProducer.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Softwa
dnhatn commented on a change in pull request #1941:
URL: https://github.com/apache/lucene-solr/pull/1941#discussion_r498957345
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -5463,6 +5463,13 @@ private void tooManyDocs(long addedNumDocs) {
D created SOLR-14911:
Summary: Looger : UpdateLog Error Message : java.io.EOFException
Key: SOLR-14911
URL: https://issues.apache.org/jira/browse/SOLR-14911
Project: Solr
Issue Type: Bug
Security L
[
https://issues.apache.org/jira/browse/SOLR-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14911.
---
Resolution: Invalid
Please raise questions like this on the user's list, we try to reserve JI
murblanc commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r498982949
##
File path:
solr/core/src/java/org/apache/solr/cluster/events/impl/CollectionsRepairEventListener.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to th
David Smiley created LUCENE-9556:
Summary: UnifiedHighlighter: distinguish no field from no passages
in field
Key: LUCENE-9556
URL: https://issues.apache.org/jira/browse/LUCENE-9556
Project: Lucene -
dsmiley commented on pull request #1942:
URL: https://github.com/apache/lucene-solr/pull/1942#issuecomment-702948130
> it was often an error to have logging calls with exception.getMessage()
Ah; right, I agree with this very much and I thought I proposed this rule.
> WDYT abo
[
https://issues.apache.org/jira/browse/SOLR-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206507#comment-17206507
]
David Smiley commented on SOLR-10321:
-
Looking back at this... I think I'm inclined t
[
https://issues.apache.org/jira/browse/SOLR-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter updated SOLR-14659:
--
Status: Patch Available (was: Open)
> Remove restlet from Solr
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-14766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206513#comment-17206513
]
Timothy Potter commented on SOLR-14766:
---
I moved the work over to SOLR-14659. The i
dnhatn merged pull request #1941:
URL: https://github.com/apache/lucene-solr/pull/1941
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dnhatn commented on pull request #1941:
URL: https://github.com/apache/lucene-solr/pull/1941#issuecomment-702967476
Thanks Mike!
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/LUCENE-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206528#comment-17206528
]
ASF subversion and git services commented on LUCENE-9554:
-
Commi
dnhatn opened a new pull request #1944:
URL: https://github.com/apache/lucene-solr/pull/1944
Some applications can use the pendingNumDocs from IndexWriter to
estimate that the number of documents of an index is very close to the
hard limit so that it can reject writes without construc
dnhatn merged pull request #1944:
URL: https://github.com/apache/lucene-solr/pull/1944
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206550#comment-17206550
]
ASF subversion and git services commented on LUCENE-9554:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nhat Nguyen resolved LUCENE-9554.
-
Fix Version/s: 8.7
master (9.0)
Resolution: Fixed
> Expose pendingNumD
[
https://issues.apache.org/jira/browse/SOLR-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
D updated SOLR-14911:
-
Summary: Logger : UpdateLog Error Message : java.io.EOFException (was:
Looger : UpdateLog Error Message : java.io.EOFExc
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206584#comment-17206584
]
Noble Paul commented on SOLR-14749:
---
{quote}I had the impression we are having a proper
noblepaul commented on pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#issuecomment-703029595
@thelabdude if all the tests pass, I wish this get committed to 8.x itself.
This is an automated message
[
https://issues.apache.org/jira/browse/SOLR-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206585#comment-17206585
]
Noble Paul commented on SOLR-14659:
---
I wish we could get rid of the {{RestManager}} nam
thelabdude commented on pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#issuecomment-703034422
Ok, I'm good with that, mainly just wanted some buy-in from others ;-)
Unless there are any objections, I'll move ahead with merging to master and 8.x
... thanks for the
dsmiley commented on a change in pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#discussion_r499113148
##
File path: solr/core/src/java/org/apache/solr/rest/RestManager.java
##
@@ -16,15 +16,33 @@
*/
package org.apache.solr.rest;
+import org.apache
dsmiley commented on a change in pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#discussion_r499113760
##
File path: solr/core/src/java/org/apache/solr/rest/RestManager.java
##
@@ -326,44 +327,46 @@ public void doInit() throws ResourceException {
[
https://issues.apache.org/jira/browse/SOLR-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206601#comment-17206601
]
Noble Paul commented on SOLR-14659:
---
This does not introduce any backward incompatible
66 matches
Mail list logo
