ErickErickson commented on pull request #1942:
URL: https://github.com/apache/lucene-solr/pull/1942#issuecomment-702826141
It was decided (there’s a phrase I hate, used to avoid taking responsibility
for something)…
Anyway, Andras Salamon and I decided that it was often an error to have
logging calls with exception.getMessage() rather than the full stack trace,
see: SOLR-14523 and the checking code isn’t sophisticated enough to figure out
that this call to getMessage() has nothing to do with an exception. This is a
case that doesn’t matter whether it’s in an "if (loglevelenabled)” clause or
not…
WDYT about adding a reference to SOLR-14523 to the output message? That’s
not obvious on a code review unfortunately...
> On Oct 2, 2020, at 11:22 AM, David Smiley <notificati...@github.com> wrote:
>
>
> @dsmiley commented on this pull request.
>
> In solr/core/src/java/org/apache/solr/servlet/ :
>
> > @@ -493,7 +493,7 @@ Action authorize() throws IOException {
> }
> if (statusCode == AuthorizationResponse.FORBIDDEN.statusCode) {
> if (log.isDebugEnabled()) {
> - log.debug("UNAUTHORIZED auth header {} context : {}, msg: {}",
req.getHeader("Authorization"), context, authResponse.getMessage()); // logOk
> + log.debug("UNAUTHORIZED auth header {} context : {}, msg: {}",
req.getHeader("Authorization"), context, authResponse.getMessage()); // nowarn
>
> What does our source validation complain about here?
>
> Many of the logok/nowarn places look fine to me at a glance but I'm no
match for the logging policeman ;-)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
