mikemccand commented on a change in pull request #1941:
URL: https://github.com/apache/lucene-solr/pull/1941#discussion_r498937003
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -5463,6 +5463,13 @@ private void tooManyDocs(long addedNumDocs) {
throw new IllegalArgumentException("number of documents in the index
cannot exceed " + actualMaxDocs + " (current document count is " +
pendingNumDocs.get() + "; added numDocs is " + addedNumDocs + ")");
}
+ /**
+ * Returns the number of documents in the index including documents are
being added (i.e., reserved).
+ */
Review comment:
Maybe add `@lucene.experimental`? We are exposing (slightly) internal
details about `IndexWriter` so maybe we need to reserve the right to change
this API in the future ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
