muse-dev[bot] commented on a change in pull request #1938: URL: https://github.com/apache/lucene-solr/pull/1938#discussion_r498956758
########## File path: solr/core/src/java/org/apache/solr/rest/RestManager.java ########## @@ -160,6 +156,10 @@ private Pattern getReservedEndpointsPattern() { return Pattern.compile(builder.toString()); } + public boolean isPathRegistered(String s) { + return registered.containsKey(s); Review comment: *THREAD_SAFETY_VIOLATION:* Read/Write race. Non-private method `RestManager$Registry.isPathRegistered(...)` reads without synchronization from container `this.registered` via call to `Map.containsKey(...)`. Potentially races with write in method `RestManager$Registry.registerManagedResource(...)`. Reporting because another access to the same memory occurs on a background thread, although this access may not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org