dsmiley commented on a change in pull request #1921:
URL: https://github.com/apache/lucene-solr/pull/1921#discussion_r498832396
##########
File path: solr/solr-ref-guide/src/common-query-parameters.adoc
##########
@@ -307,11 +307,13 @@ The `echoParams` parameter controls what information
about request parameters is
The `echoParams` parameter accepts the following values:
-* `explicit`: This is the default value. Only parameters included in the
actual request, plus the `_` parameter (which is a 64-bit numeric timestamp)
will be added to the `params` section of the response header.
+* `explicit`: Only parameters included in the actual request, plus the `_`
parameter (which is a 64-bit numeric timestamp) will be added to the `params`
section of the response header.
Review comment:
I did some digging and discovered that the admin UI will add this
underscore. See `services.js` which does this via `Date.now()` all over the
place. I don't know what purpose it has; git blame shows it was added with
that whole UI refactor of it's day but perhaps it predated it? AFAICT Solr
isn't doing anything with it Solr side; I set multiple conditional debugger
breakpoints across SolrParams subclasses but no where is "_" requested. My
suspicion is that it was added to foil HTTP cache attempts?
I did some JIRA digging and found:
https://issues.apache.org/jira/browse/SOLR-4311 which has a patch with the
underscores but it was for version, not the timestamp. Given the underscore's
use to defeat bad caching in that scenario, if I keep digging, I'll probably
find it.
In short, I don't think we should document this underscore param in the ref
guide. It's not a special param to Solr; it's an oddity of our current admin
UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]