[GitHub] [lucene-solr] uschindler commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-03 Thread GitBox
uschindler commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686302137 Is there a way to enable/disable checks using a config file? Things like ReferenceEquality in Lucene Code is annoying. It should be disabled there. I love th

[jira] [Created] (LUCENE-9502) Can we remove JaspellLookup?

2020-09-03 Thread Simon Willnauer (Jira)
Simon Willnauer created LUCENE-9502: --- Summary: Can we remove JaspellLookup? Key: LUCENE-9502 URL: https://issues.apache.org/jira/browse/LUCENE-9502 Project: Lucene - Core Issue Type: Wish

[GitHub] [lucene-solr] chatman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686308531 > You need to make a realistic proposal here IMO @noblepaul. > And we need something that already exists. If placement plugins depend on some > future rehaul of configu

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-03 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482772181 ## File path: lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java ## @@ -202,4 +203,63 @@ public BytesRef binaryValue() {

[GitHub] [lucene-solr] chatman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686316250 > If the plugin requests data node by node, it's either sequential or forces the plugin to implement the concurrency mechanism itself, making it more complicated. Plu

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9500: - Attachment: PresetDictTest.java Status: Open (was: Open) New version of the reproductio

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9500: - Attachment: (was: PresetDictTest.java) > Did we hit a DEFLATE bug? > ---

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686318299 > don't like an explosion of classes but I think this is highly mitigated by them being defined as simple inner classes of one outer class, as Ilan has done. Yeah, t

[GitHub] [lucene-solr] noblepaul removed a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul removed a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686318299 > don't like an explosion of classes but I think this is highly mitigated by them being defined as simple inner classes of one outer class, as Ilan has done.

[GitHub] [lucene-solr] chatman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686320915 > Yeah, the solution to API surface area problem is to make them inner classes/interfaces. This is such a elegant & simple proposition. We should try the same in other place

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686321426 The consistent theme I see here is A. Here's is my elegant solution to the problem B. I think the solution is -

[GitHub] [lucene-solr] murblanc opened a new pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
murblanc opened a new pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684 SOLR-14613: strongly typed initial proposal for plugin interface to replace Autoscaling This is not meant to be merged, it's to share early for feedback. Still WIP, any feedback most wel

[GitHub] [lucene-solr] noblepaul closed pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul closed pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189920#comment-17189920 ] Uwe Schindler commented on LUCENE-9500: --- Thanks Adrien, I attach it to the issue I

[GitHub] [lucene-solr] chatman edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686320915 > Yeah, the solution to API surface area problem is to make them inner classes/interfaces. This is such a elegant & simple proposition. We should try the same in othe

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686327240 > Here's an example @noblepaul of how your proposal would be used (and if I misunderstood something, please correct). nodes are the cluster nodes of interest: I

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189937#comment-17189937 ] Uwe Schindler commented on LUCENE-9500: --- Status info: Java 8 is fine, the bug was

[GitHub] [lucene-solr] sigram commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482794634 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementPluginFactoryFacade.java ## @@ -0,0 +1,75 @@ +/* + * Licensed to the

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189940#comment-17189940 ] Uwe Schindler commented on LUCENE-9500: --- I am wondering: Does this really happen w

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189941#comment-17189941 ] Uwe Schindler commented on LUCENE-9500: --- Looks like this was introduced here: htt

[GitHub] [lucene-solr] sigram commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482798947 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/SolrCollection.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [lucene-solr] sigram commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482799416 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PluginInteractionsImpl.java ## @@ -0,0 +1,190 @@ +/* Review comment: H

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189945#comment-17189945 ] Uwe Schindler commented on LUCENE-9500: --- JDK Issue is here: https://bugs.openjdk.j

[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686342727 > ``` > Iterable values = someFactory.createPropertyFetcher() > .withSystemProperty("AvailabilityZone") >.withCoresCount() > .fetchFromAllNodes()

[GitHub] [lucene-solr] sigram commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
sigram commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686346534 @noblepaul & @chatman I find the tone of your latest comments offensive - that's no way to build a consensus. Please think twice before posting and calm down - if you have a

[GitHub] [lucene-solr] chatman removed a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman removed a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686320915 > Yeah, the solution to API surface area problem is to make them inner classes/interfaces. This is such a elegant & simple proposition. We should try the same in oth

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482813142 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/SolrCollection.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482813142 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/SolrCollection.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] sigram commented on pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-09-03 Thread GitBox
sigram commented on pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686349516 This approach was something that I suggested for branch_8x only, and only because the Policy-based placements didn't work and I needed a critical fix. This approach has minim

[jira] [Commented] (SOLR-14820) Create replica is broken

2020-09-03 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189958#comment-17189958 ] Thomas Wöckinger commented on SOLR-14820: - The setup consists of three hosts, on

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189963#comment-17189963 ] Uwe Schindler commented on LUCENE-9500: --- The whole thing was introduced in JDK 11.

[GitHub] [lucene-solr] chatman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686355702 > @noblepaul & @chatman I find the tone of your latest comments offensive - that's no way to build a consensus. Please think twice before posting and calm down - if you have

[jira] [Comment Edited] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189963#comment-17189963 ] Uwe Schindler edited comment on LUCENE-9500 at 9/3/20, 9:01 AM: --

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9500: -- Component/s: core/index > Did we hit a DEFLATE bug? > - > >

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9500: -- Affects Version/s: master (9.0) > Did we hit a DEFLATE bug? > - > >

[jira] [Comment Edited] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189963#comment-17189963 ] Uwe Schindler edited comment on LUCENE-9500 at 9/3/20, 9:02 AM: --

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9500: -- Labels: Java13 Java14 Java15 java11 jdk11 jdk13 jdk14 jdk15 (was: ) > Did we hit a DEFLATE bu

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189977#comment-17189977 ] Uwe Schindler commented on LUCENE-9500: --- [~jpountz]: I am not sure how to handle t

[GitHub] [lucene-solr] chatman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686357674 > Please also remember that we are on a deadline - we need to have some kind of replacement for the autoscaling in 9.0. +1, this is the cause for maximum urgency at th

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686359748 > By all means, if you disagree so strongly with the approach presented here then please do so I clearly have objections to the verbosity of the proposals here. This

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686359748 > By all means, if you disagree so strongly with the approach presented here then please do so I clearly have objections to the verbosity of the proposals her

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686359748 > By all means, if you disagree so strongly with the approach presented here then please do so I clearly have objections to the verbosity of the proposals her

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686359748 > By all means, if you disagree so strongly with the approach presented here then please do so I clearly have objections to the verbosity of the proposals her

[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686368990 > On the other hand, Ilan wrote this on Slack: > > > If there’s consensus for Noble’s approach (or for that matter no consensus that goals 1-3 above are good guiding

[GitHub] [lucene-solr] jpountz merged pull request #1787: LUCENE-9483: Disable per-thread caching of buffers for decompression of stored fields.

2020-09-03 Thread GitBox
jpountz merged pull request #1787: URL: https://github.com/apache/lucene-solr/pull/1787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189996#comment-17189996 ] Adrien Grand commented on LUCENE-9500: -- I'm seeing only a 1-2% slowdown when copyin

[jira] [Commented] (LUCENE-9483) Disable per-thread caching of buffers for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190009#comment-17190009 ] ASF subversion and git services commented on LUCENE-9483: - Commi

[GitHub] [lucene-solr] jpountz merged pull request #1817: Improve how Asserting* classes handle singleton doc values.

2020-09-03 Thread GitBox
jpountz merged pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9438) Add gradle workflow support for Eclipse IDE

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190003#comment-17190003 ] ASF subversion and git services commented on LUCENE-9438: - Commi

[jira] [Commented] (LUCENE-9483) Disable per-thread caching of buffers for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190005#comment-17190005 ] ASF subversion and git services commented on LUCENE-9483: - Commi

[jira] [Commented] (LUCENE-8500) smokeTestRelease still expects KEYS file in distribution

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190004#comment-17190004 ] ASF subversion and git services commented on LUCENE-8500: - Commi

[jira] [Commented] (LUCENE-8500) smokeTestRelease still expects KEYS file in distribution

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190002#comment-17190002 ] ASF subversion and git services commented on LUCENE-8500: - Commi

[jira] [Commented] (SOLR-14794) Pass global cloud configuration to Collection API command execution

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190013#comment-17190013 ] ASF subversion and git services commented on SOLR-14794: Commit 6

[GitHub] [lucene-solr] chatman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686380223 I broadly agree with those principals, and I'm sure everyone does. >1. placement plugin writing is easy, Agree, but not at the cost of complicated server side c

[GitHub] [lucene-solr] chatman edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686380223 I broadly agree with those principals, and I'm sure everyone does. >1. placement plugin writing is easy, Agree, but not at the cost of complicated se

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190018#comment-17190018 ] Uwe Schindler commented on LUCENE-9500: --- I have seen your fix also in branch_8x. B

[jira] [Commented] (SOLR-14819) SOLR has linear log operations that could trivially be linear

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190024#comment-17190024 ] ASF subversion and git services commented on SOLR-14819: Commit 2

[GitHub] [lucene-solr] bruno-roustant closed pull request #1818: SOLR-14819 Trivial fix to inefficient iterator pattern

2020-09-03 Thread GitBox
bruno-roustant closed pull request #1818: URL: https://github.com/apache/lucene-solr/pull/1818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [lucene-solr] jpountz merged pull request #1793: LUCENE-9486: Use preset dictionaries with LZ4 for BEST_SPEED.

2020-09-03 Thread GitBox
jpountz merged pull request #1793: URL: https://github.com/apache/lucene-solr/pull/1793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190029#comment-17190029 ] ASF subversion and git services commented on LUCENE-9486: - Commi

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190030#comment-17190030 ] Adrien Grand commented on LUCENE-9500: -- [~uschindler] This code was backported alre

[jira] [Commented] (LUCENE-8500) smokeTestRelease still expects KEYS file in distribution

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190032#comment-17190032 ] Adrien Grand commented on LUCENE-8500: -- Woops, wrong JIRA, this should have been LU

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-09-03 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190033#comment-17190033 ] Ishan Chattopadhyaya commented on SOLR-14588: - bq. Fixed configuration in ht

[jira] [Commented] (SOLR-14819) SOLR has linear log operations that could trivially be linear

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190034#comment-17190034 ] ASF subversion and git services commented on SOLR-14819: Commit c

[GitHub] [lucene-solr] noblepaul commented on pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-09-03 Thread GitBox
noblepaul commented on pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686400974 > However, for master/trunk we need a better design anyway. I would say that most users are actually happy if they do not have to implement a bunch of java interface

[jira] [Resolved] (SOLR-14819) SOLR has linear log operations that could trivially be linear

2020-09-03 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-14819. --- Fix Version/s: 8.7 Resolution: Fixed Thanks Thomas for this fix. Please share the inf

[jira] [Commented] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190048#comment-17190048 ] ASF subversion and git services commented on LUCENE-9486: - Commi

[jira] [Commented] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190049#comment-17190049 ] ASF subversion and git services commented on LUCENE-9486: - Commi

[GitHub] [lucene-solr] s1monw merged pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-03 Thread GitBox
s1monw merged pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] sigram commented on pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-09-03 Thread GitBox
sigram commented on pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686410621 > Honestly nobody will do that. People would rather happily do the computation in client code Really? This is like saying that we only ever need collection admin APIs a

[jira] [Commented] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190050#comment-17190050 ] ASF subversion and git services commented on LUCENE-9486: - Commi

[jira] [Commented] (LUCENE-9484) Allow index sorting to happen after the fact

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190051#comment-17190051 ] ASF subversion and git services commented on LUCENE-9484: - Commi

[jira] [Resolved] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9486. -- Fix Version/s: 8.7 Resolution: Fixed > Explore using preset dictionaries with LZ4 for s

[jira] [Resolved] (LUCENE-9483) Disable per-thread caching of buffers for stored fields

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9483. -- Resolution: Fixed > Disable per-thread caching of buffers for stored fields >

[GitHub] [lucene-solr] sigram edited a comment on pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-09-03 Thread GitBox
sigram edited a comment on pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686410621 > Honestly nobody will do that. People would rather happily do the computation in client code Really? This is like saying that we only ever need collection admin

[jira] [Commented] (LUCENE-9484) Allow index sorting to happen after the fact

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190053#comment-17190053 ] ASF subversion and git services commented on LUCENE-9484: - Commi

[GitHub] [lucene-solr] uschindler opened a new pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler opened a new pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824 A factory method allows to return a different instance depending on Java version (for now everything after Java 11 is disallowed). We can improve this when we exactly know which versions

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190063#comment-17190063 ] Uwe Schindler commented on LUCENE-9500: --- Here is a pull request that separates the

[jira] [Assigned] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-9500: - Assignee: Uwe Schindler > Did we hit a DEFLATE bug? > - > >

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686427056 This effectively reverts @jpountz's hotfix commit, but as he moved classes around in the meantime, I had to do it manually.

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
dweiss commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482922248 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java ## @@ -155,16 +155,15 @@ public Decompr

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482923181 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java ## @@ -155,16 +155,15 @@ public Dec

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482923181 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java ## @@ -155,16 +155,15 @@ public Dec

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482952318 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java ## @@ -155,16 +155,15 @@ public Dec

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686468187 Hi, I added detectction in my latest commit: ``` C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1>java -version openjdk version "11.0.2" 2019-01-15 Open

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686471292 I converted this to a draf, because checks failed with precommit. But this should stay in for doing quick checks by @jpountz like commented before! -

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
jpountz commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482960153 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apac

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
jpountz commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482962830 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apac

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
jpountz commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482963038 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apac

[jira] [Created] (SOLR-14826) Clean up package name conflicts between modules (split packages)

2020-09-03 Thread Tomoko Uchida (Jira)
Tomoko Uchida created SOLR-14826: Summary: Clean up package name conflicts between modules (split packages) Key: SOLR-14826 URL: https://issues.apache.org/jira/browse/SOLR-14826 Project: Solr

[jira] [Assigned] (SOLR-11875) merge SolrConfigXml wiki into Solr Reference Guide

2020-09-03 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch reassigned SOLR-11875: Assignee: Alexandre Rafalovitch > merge SolrConfigXml wiki into Solr Refer

[jira] [Commented] (SOLR-11875) merge SolrConfigXml wiki into Solr Reference Guide

2020-09-03 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190166#comment-17190166 ] Alexandre Rafalovitch commented on SOLR-11875: -- Could we revisit this issue

[jira] [Commented] (SOLR-13230) Move JaSpell code into Solr and deprecate the factory

2020-09-03 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190168#comment-17190168 ] Cassandra Targett commented on SOLR-13230: -- Linking a very old issue SOLR-6178 w

[jira] [Commented] (LUCENE-9502) Can we remove JaspellLookup?

2020-09-03 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190170#comment-17190170 ] Cassandra Targett commented on LUCENE-9502: --- I linked SOLR-13230, the issue to

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686528216 Hi, I did further tests (except Java 8, I need to merge first), Results looking fine: - OpenJDK JDK 11.0.2 reports **non-buggy** - AdoptJDK 11.0.5 reports **buggy

[GitHub] [lucene-solr] uschindler merged pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler merged pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190200#comment-17190200 ] ASF subversion and git services commented on LUCENE-9500: - Commi

[jira] [Created] (SOLR-14827) Refactor schema loading to not use XPath

2020-09-03 Thread Noble Paul (Jira)
Noble Paul created SOLR-14827: - Summary: Refactor schema loading to not use XPath Key: SOLR-14827 URL: https://issues.apache.org/jira/browse/SOLR-14827 Project: Solr Issue Type: Task Securi

[jira] [Updated] (SOLR-14827) Refactor schema loading to not use XPath

2020-09-03 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14827: -- Labels: perfomance (was: ) > Refactor schema loading to not use XPath > --

[jira] [Created] (LUCENE-9503) Fix comment explaining reason for 8KB buffered/chunked writes

2020-09-03 Thread Henning Andersen (Jira)
Henning Andersen created LUCENE-9503: Summary: Fix comment explaining reason for 8KB buffered/chunked writes Key: LUCENE-9503 URL: https://issues.apache.org/jira/browse/LUCENE-9503 Project: Lucene

  1   2   >