sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482794634
########## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementPluginFactoryFacade.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cluster.placement.impl; + +import org.apache.solr.cluster.placement.PlacementPlugin; +import org.apache.solr.cluster.placement.PlacementPluginConfig; +import org.apache.solr.cluster.placement.PlacementPluginFactory; +import org.apache.solr.common.SolrException; +import org.apache.solr.core.PluginInfo; +import org.apache.solr.core.SolrResourceLoader; + +/** + * <p>The internal class instantiating the configured {@link PlacementPluginFactory} and creating a {@link PlacementPlugin} + * instance by passing the the factory the appropriate configuration created from the {@code <placementPluginFactory>} + * element in {@code solr.xml}. + * + * <p>A single instance of {@link PlacementPlugin} is used for all placement computations and therefore must be reentrant. + * When configuration changes, a new instance of {@link PlacementPlugin} will be created by calling again + * {@link PlacementPluginFactory#createPluginInstance(PlacementPluginConfig)}. + */ +public class PlacementPluginFactoryFacade { Review comment: Oh, indeed - sorry for the confusion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
