noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686327240
> Here's an example @noblepaul of how your proposal would be used (and if I
misunderstood something, please correct). nodes are the cluster nodes of
interest:
I'm not writing full PRs here.The objective was to give you hints as to how
to do things differently .
With a little more imagination, the code would look as follows.
The following could
- make requests in multiple thread
- minimal code
```
Iterable<PropertyValues> values = someFactory.createPropertyFetcher()
.withSystemProperty("AvailabilityZone")
.withCoresCount()
.fetchFromAllNodes()
```
or
```
PropertyValues values = someFactory.createPropertyFetcher()
.withSystemProperty("AvailabilityZone")
.withCoresCount()
.fetchFromNode("nodeName")
```
The common theme I see here is instead of trying to understand the spirit of
suggestions, you are trying to pick holes in the suggestions. I could as well
create a full framework and give a PR. Then you would say that "I do not want
to work on somebody else's design".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
