sigram commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686346534
@noblepaul & @chatman I find the tone of your latest comments offensive - that's no way to build a consensus. Please think twice before posting and calm down - if you have a different opinion about technical merits of this PR then I'm sure you can express it without personal attacks. Hiding the complexity of multi-node interactions from plugin implementations is a worthy goal IMO - and not because we don't know how to write multi-threaded code, but because most devs know how to do it poorly ;) If we can hide this complexity from the plugin writers then we increase the chance for the plugins to work well and efficiently. > I could as well create a full framework and give a PR. By all means, if you disagree so strongly with the approach presented here then please do so - just be sure that you actually will do it instead of just complaining. I'll gladly review it and I will gladly collaborate with you if it moves us forward toward the same goal - which is a strongly-typed API for placement plugins :) Please also remember that we are on a deadline - we need to have some kind of replacement for the autoscaling in 9.0. The impl. can be barebones, but the API that we define is going to stay with us for the next couple years at least, so it pays off to think seriously how to do it in an elegant and efficient way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
