atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444749060
##
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##
@@ -224,6 +224,13 @@ private SolrConfig(SolrResourceLoader loader, String name,
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444750302
##
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##
@@ -1164,6 +1171,16 @@ private SolrCoreMetricManager
initCoreMetricManager(SolrC
atris commented on pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648696657
@madrob @anshumg Thanks for reviewing -- I have updated per comments. Please
see and let me know if it looks fine.
---
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444798477
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Softw
atris commented on pull request #1603:
URL: https://github.com/apache/lucene-solr/pull/1603#issuecomment-648741044
Seems erratical.
This is an automated message from the Apache Git Service.
To respond to the message, please l
atris closed pull request #1603:
URL: https://github.com/apache/lucene-solr/pull/1603
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jimczi commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444817529
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
toAutomatonInternal(Map auto
gerlowskija commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r444844913
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -500,6 +509,29 @@ public void handleRequestBody(SolrQ
gerlowskija commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r444845331
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -70,6 +73,11 @@
private static final Logger log
gerlowskija commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r444844913
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -500,6 +509,29 @@ public void handleRequestBody(SolrQ
gerlowskija commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r444855333
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -500,6 +509,29 @@ public void handleRequestBody(SolrQ
sigram commented on pull request #1598:
URL: https://github.com/apache/lucene-solr/pull/1598#issuecomment-648800310
This change fixes the original issue, so it's +1 on the change.
However, please note that the tests contain many unchecked casts and these
need to be fixed before commi
Erick Erickson created SOLR-14591:
-
Summary: Move JoinQuery in JoinQParserPlugin to its own class
Key: SOLR-14591
URL: https://issues.apache.org/jira/browse/SOLR-14591
Project: Solr
Issue Typ
gerlowskija commented on pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#issuecomment-648812127
> Perhaps a stupid question, but how does this compare with the
jaegertracing / opentracing support? Would not that already provide some
request id to follow a request a
gerlowskija edited a comment on pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#issuecomment-648812127
> Perhaps a stupid question, but how does this compare with the
jaegertracing / opentracing support? Would not that already provide some
request id to follow a re
gerlowskija commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r444888654
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -500,6 +509,29 @@ public void handleRequestBody(SolrQ
dsmiley commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r444916722
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -500,6 +509,29 @@ public void handleRequestBody(SolrQuery
dsmiley commented on pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#issuecomment-648847445
I agree with Jason's characterization relating to multiple use-cases, but
there is overlap, and it'd be nice to see shared code for overlapping concerns
instead of completel
bruno-roustant opened a new pull request #1608:
URL: https://github.com/apache/lucene-solr/pull/1608
Performance issue because of too many new Ciphers when slicing IndexInput.
javax.crypto.Cipher is heavy weight to create and is stateful. I tried a
CipherPool, but actually there are many
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143881#comment-17143881
]
Simon Willnauer commented on LUCENE-8962:
-
I agree mike! I looked into it and it
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143886#comment-17143886
]
Bruno Roustant commented on LUCENE-9379:
First PR, functional but incomplete. Th
madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444952555
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Soft
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143890#comment-17143890
]
Michael Sokolov commented on LUCENE-8962:
-
[~simonw] I think we can continue to
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143912#comment-17143912
]
Jun Ohtani commented on LUCENE-9286:
I made pull request for adding Kuromoji to luce
Mohammad Sadiq created LUCENE-9416:
--
Summary: Fix CheckIndex to print norms as unsigned integers
Key: LUCENE-9416
URL: https://issues.apache.org/jira/browse/LUCENE-9416
Project: Lucene - Core
madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444955220
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache So
atris opened a new pull request #1609:
URL: https://github.com/apache/lucene-solr/pull/1609
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Atri Sharma reassigned SOLR-14591:
--
Assignee: Atri Sharma (was: Erick Erickson)
> Move JoinQuery in JoinQParserPlugin to its own
[
https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143933#comment-17143933
]
Atri Sharma commented on SOLR-14591:
[~erickerickson] I have raised a PR for this – p
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143935#comment-17143935
]
Mike Drob commented on SOLR-14576:
--
I'm worried about two things here -
1) Using String
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143941#comment-17143941
]
Mike Drob commented on SOLR-14586:
--
I'm still very interested in hearing from [~ab] when
mayya-sharipova opened a new pull request #1610:
URL: https://github.com/apache/lucene-solr/pull/1610
Backport for: LUCENE-9280: Collectors to skip noncompetitive documents
(#1351)
Similar how scorers can update their iterators to skip non-competitive
documents, collectors and com
juanka588 commented on a change in pull request #1608:
URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r444988334
##
File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foun
[
https://issues.apache.org/jira/browse/SOLR-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-14524.
--
Resolution: Fixed
re-resolving since linked issue is done
> Harden MultiThreadedOCPTest
>
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444988588
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Softw
[
https://issues.apache.org/jira/browse/SOLR-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-10027.
--
Resolution: Duplicate
> TestCoreDiscovery.testCoreDirCantRead fails when run as superuser
> ---
juanka588 commented on a change in pull request #1608:
URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r444991113
##
File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foun
mikemccand commented on a change in pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r444984980
##
File path:
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMergePolicy.java
##
@@ -396,10 +396,12 @@ protected void merge(MergePoli
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444994179
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Sof
[
https://issues.apache.org/jira/browse/SOLR-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-8354.
-
Resolution: Duplicate
Fixed in 75b183196798232aa6f2dcb117f309119053
> RecoveryStrategy retry timing i
atris commented on pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648911905
> How does this work for distributed requests? When the coordinator node is
under memory pressure? When one of the fan out nodes in under memory pressure?
I believe the
ErickErickson commented on pull request #1609:
URL: https://github.com/apache/lucene-solr/pull/1609#issuecomment-648913033
OK, I'm messing up the reviewer thing, ignore it.
This is exactly what I was going to do, please go ahead and merge it in.
-
atris merged pull request #1609:
URL: https://github.com/apache/lucene-solr/pull/1609
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
atris commented on pull request #1609:
URL: https://github.com/apache/lucene-solr/pull/1609#issuecomment-648914229
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143971#comment-17143971
]
Erick Erickson commented on SOLR-14591:
---
[~atris]
This is exactly what I was going
[
https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143974#comment-17143974
]
ASF subversion and git services commented on SOLR-14591:
Commit 7
s1monw commented on a change in pull request #1590:
URL: https://github.com/apache/lucene-solr/pull/1590#discussion_r445010346
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4286,25 +4287,30 @@ private synchronized void
mergeFinish(MergePoli
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445011734
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Softw
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445015098
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -289,6 +295,19 @@ public void handleRequestBody(SolrQueryRe
s1monw commented on a change in pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r445021609
##
File path:
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMergePolicy.java
##
@@ -396,10 +396,12 @@ protected void merge(MergePolicy.O
[
https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144021#comment-17144021
]
David Smiley commented on SOLR-14591:
-
I this _also_ changed the visibility of JoinQu
[
https://issues.apache.org/jira/browse/SOLR-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144033#comment-17144033
]
Atri Sharma commented on SOLR-14591:
I I made it public since it seems weird to have
s1monw closed pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
s1monw commented on pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#issuecomment-648938745
I pushed all the commits and fixes for your comments to this branch
https://github.com/apache/lucene-solr/tree/jira/lucene-8962
-
atris opened a new pull request #1611:
URL: https://github.com/apache/lucene-solr/pull/1611
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
atris commented on pull request #1611:
URL: https://github.com/apache/lucene-solr/pull/1611#issuecomment-648941896
@dsmiley Updated as per discussion
This is an automated message from the Apache Git Service.
To respond to the
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445038316
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Sof
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445038817
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -289,6 +295,19 @@ public void handleRequestBody(SolrQueryRe
atris commented on pull request #1611:
URL: https://github.com/apache/lucene-solr/pull/1611#issuecomment-648943830
Cool, thanks. Will merge post the CI completion, just to be sure :)
This is an automated message from the Apac
madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445046053
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -289,6 +295,19 @@ public void handleRequestBody(SolrQueryR
atris merged pull request #1611:
URL: https://github.com/apache/lucene-solr/pull/1611
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445063185
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Softw
[
https://issues.apache.org/jira/browse/SOLR-14590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144109#comment-17144109
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14590:
--
Discussed th
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445082883
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Softw
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445094485
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -289,6 +295,19 @@ public void handleRequestBody(SolrQueryRe
atris commented on pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648995835
@madrob Updated, please see and let me know your thoughts and comments.
This is an automated message from the
[
https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144216#comment-17144216
]
Cassandra Targett commented on SOLR-14329:
--
[~munendrasn], Sorry about that, I m
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144227#comment-17144227
]
Ryan Ernst commented on LUCENE-9221:
[~bkazar] I think the Apache text needs to be i
s1monw merged pull request #1590:
URL: https://github.com/apache/lucene-solr/pull/1590
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144230#comment-17144230
]
ASF subversion and git services commented on LUCENE-9408:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144231#comment-17144231
]
ASF subversion and git services commented on LUCENE-9408:
-
Commi
murblanc merged pull request #1504:
URL: https://github.com/apache/lucene-solr/pull/1504
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/SOLR-14462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144258#comment-17144258
]
ASF subversion and git services commented on SOLR-14462:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-14462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144259#comment-17144259
]
ASF subversion and git services commented on SOLR-14462:
Commit 2
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144353#comment-17144353
]
BARIS KAZAR commented on LUCENE-9221:
-
Ryan,-
i will do that today.
Thanks
>
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144366#comment-17144366
]
Simon Willnauer commented on LUCENE-8962:
-
[~sokolov] thanks, I updated the bran
[
https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144385#comment-17144385
]
David Smiley commented on SOLR-13688:
-
[~jbernste] just curious; if the ExportTool ha
[
https://issues.apache.org/jira/browse/LUCENE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144406#comment-17144406
]
ASF subversion and git services commented on LUCENE-6669:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-6669.
---
Fix Version/s: master (9.0)
Assignee: Mike Drob
Resolution: Fixed
Saw this while goi
madrob opened a new pull request #1612:
URL: https://github.com/apache/lucene-solr/pull/1612
cc: @cpoerschke I can't tag you as a reviewer for some reason, but this is
based on your patch and I added two more changes - fixed spelling and removed
back link from DatePoint to TrieDate.
madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445188767
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -44,25 +48,20 @@ public boolean isCircuitBreakerG
[
https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer resolved LUCENE-9408.
-
Resolution: Fixed
> OneMerge#mergeFinish is called multiple times
>
[
https://issues.apache.org/jira/browse/LUCENE-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-9408:
Fix Version/s: 8.6
master (9.0)
> OneMerge#mergeFinish is called multip
zhaih opened a new pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613
# Description
* Add a new DoubleValuesSource which will enforce only one value per name
in dependencies
* Add few fields to `ExpressionFunctionValues` to ensure for a given
[
https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144550#comment-17144550
]
Chris M. Hostetter commented on SOLR-13132:
---
I pushed a few commits to your bra
[
https://issues.apache.org/jira/browse/LUCENE-8716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved LUCENE-8716.
Resolution: Won't Fix
I've essentially given up on this, see the comments in SOLR-13268.
[
https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144556#comment-17144556
]
ASF subversion and git services commented on SOLR-14409:
Commit 4
noblepaul merged pull request #1598:
URL: https://github.com/apache/lucene-solr/pull/1598
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144555#comment-17144555
]
ASF subversion and git services commented on SOLR-14409:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144558#comment-17144558
]
Noble Paul commented on SOLR-14586:
---
There is no need to rush on this. if anything, thi
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144561#comment-17144561
]
Noble Paul commented on SOLR-14576:
---
{quote}Using String as a key in an Identity HashMa
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144561#comment-17144561
]
Noble Paul edited comment on SOLR-14576 at 6/25/20, 12:40 AM:
-
Erick Erickson created SOLR-14592:
-
Summary: Upgrade Zookeeper to 3.6.1
Key: SOLR-14592
URL: https://issues.apache.org/jira/browse/SOLR-14592
Project: Solr
Issue Type: Bug
Security Leve
ErickErickson commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445252504
##
File path: solr/core/src/java/org/apache/solr/pkg/PackageAPI.java
##
@@ -211,7 +211,7 @@ public boolean equals(Object obj) {
@Override
ErickErickson commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445252535
##
File path: solr/core/src/java/org/apache/solr/cloud/rule/Rule.java
##
@@ -365,7 +365,7 @@ public boolean equals(Object obj) {
@Overrid
[
https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144574#comment-17144574
]
ASF subversion and git services commented on SOLR-14409:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144575#comment-17144575
]
ASF subversion and git services commented on SOLR-14409:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-14409.
---
Resolution: Fixed
> Existing violations allow bypassing policy rules when adding new replicas
> -
ErickErickson commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445257281
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java
##
@@ -305,10 +303,10 @@ public boolean
ErickErickson commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445260567
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java
##
@@ -587,11 +585,11 @@ public boolean
1 - 100 of 146 matches
Mail list logo
