atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444749060
##########
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##########
@@ -224,6 +224,13 @@ private SolrConfig(SolrResourceLoader loader, String name,
boolean isConfigsetTr
queryResultWindowSize = Math.max(1, getInt("query/queryResultWindowSize",
1));
queryResultMaxDocsCached = getInt("query/queryResultMaxDocsCached",
Integer.MAX_VALUE);
enableLazyFieldLoading = getBool("query/enableLazyFieldLoading", false);
+
+ useCircuitBreakers = getBool("query/useCircuitBreakers", false);
+ memoryCircuitBreakerThreshold =
getInt("query/memoryCircuitBreakerThreshold", 100);
+
+ if (memoryCircuitBreakerThreshold > 100 || memoryCircuitBreakerThreshold <
0) {
Review comment:
I have changed the check to be only performed when circuit breakers are
enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
