madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r445046053
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##########
@@ -289,6 +295,19 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
rb.requestInfo.setResponseBuilder(rb);
}
+ //TODO: Should this be for indexing requests as well?
+ CircuitBreakerManager circuitBreakerManager =
req.getCore().getCircuitBreakerManager();
+ Map<CircuitBreakerType, CircuitBreaker> trippedCircuitBreakers =
circuitBreakerManager.checkAllCircuitBreakers();
Review comment:
I mean in response we send timing info with `debug=true`(see `RTimerTree
subt = timer.sub( "prepare" );`), maybe this is worthwhile to include there as
well since otherwise the times may not add up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
