juanka588 commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r444988334
########## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.store; + +import java.io.IOException; + +import org.apache.lucene.index.SegmentInfo; + +public class EncryptingDirectory extends FilterDirectory { + + private final KeySupplier keySupplier; + private final SegmentKeySupplier segmentKeySupplier; + private final SegmentInfo segmentInfo; + + public EncryptingDirectory(Directory directory, KeySupplier keySupplier) { Review comment: you can create two objects: one with the keySupplier and the directory, the second one with the segment key supplier and segment info and instead of using the constructors use an static factory method ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
