zhaih opened a new pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613


   <!--
   _(If you are a project committer then you may remove some/all of the 
following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system 
for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people 
scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly 
updated with code review comments and commits. -->
   
   
   # Description
   
    * Add a new DoubleValuesSource which will enforce only one value per name
   in dependencies
    * Add few fields to `ExpressionFunctionValues` to ensure for a given doc, 
it is only computed once
    * Added a unit test that need this mechanism to pass, otherwise would cost
   huge memory and time
   
   `ant test` and `ant precommit` passed
   
   # Solution
   
   In `CachingExpressionValuesSource`, a modified version of `getValues` is 
used to get `DoubleValues`, it will be called with additional `valueCache` 
passed in and update `valueCache` along the creation process to ensure only one 
value per name is created.
   
   # Tests
   
   A new test method `testFibonacciExpr` is added to 
`TestExpressionValueSource` to show the difference, normally it takes 1.x sec 
on my laptop with `n=30`, and much longer when `n=40` because of the 
exponential growth.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [x] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to