[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134007#comment-17134007
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134008#comment-17134008
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand reopened LUCENE-9356:
--
I reverted the test, there are still some cases that wouldn't cause a
CorruptIndexException and t
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134048#comment-17134048
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Salamon updated LUCENE-9389:
---
Attachment: LUCENE-9389.patch
> Enhance gradle logging calls validation: eliminate getMessag
[
https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134132#comment-17134132
]
Andras Salamon commented on LUCENE-9389:
All the listed lucene (luke) logs had t
[
https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Salamon updated LUCENE-9389:
---
Status: Patch Available (was: Open)
> Enhance gradle logging calls validation: eliminate ge
msokolov merged pull request #1563:
URL: https://github.com/apache/lucene-solr/pull/1563
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134138#comment-17134138
]
ASF subversion and git services commented on LUCENE-9394:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134137#comment-17134137
]
ASF subversion and git services commented on LUCENE-9394:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Sokolov updated LUCENE-9394:
Fix Version/s: master (9.0)
> Fix or suppress compile-time warnings
>
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Sokolov resolved LUCENE-9394.
-
Assignee: Michael Sokolov
Resolution: Fixed
> Fix or suppress compile-time warning
Erick Erickson created SOLR-14563:
-
Summary: Fix or suppress warnings in solr/contrib
Key: SOLR-14563
URL: https://issues.apache.org/jira/browse/SOLR-14563
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-10810.
---
Resolution: Duplicate
This is all being handled in other JIRAs, particularly SOLR-10778 this
[
https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134165#comment-17134165
]
Erick Erickson commented on LUCENE-9389:
This looks good, anyone object to me pu
[
https://issues.apache.org/jira/browse/SOLR-14534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson reassigned SOLR-14534:
-
Assignee: Erick Erickson
> Investigate cleaning up any remaining warnings in 8x
> --
Erick Erickson created SOLR-14564:
-
Summary: Fix or suppress remaining warnings in solr/core
Key: SOLR-14564
URL: https://issues.apache.org/jira/browse/SOLR-14564
Project: Solr
Issue Type: Su
Erick Erickson created SOLR-14565:
-
Summary: Fix or suppress warnings in solrj/impl and solrj/io/graph
Key: SOLR-14565
URL: https://issues.apache.org/jira/browse/SOLR-14565
Project: Solr
Issu
mikemccand commented on pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-643263358
> > @gandhi-viral That would work for me but I'd like to make sure we're
talking about the same thing:
> >
> > * Lucene86DocValuesConsumer gets a ctor argument to c
[
https://issues.apache.org/jira/browse/SOLR-14534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134213#comment-17134213
]
Michael Sokolov commented on SOLR-14534:
I decided not to backport LUCENE-9394, c
[
https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134216#comment-17134216
]
Erick Erickson commented on SOLR-14541:
---
These classes have SuppressWarnings that s
[
https://issues.apache.org/jira/browse/SOLR-14534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134222#comment-17134222
]
Erick Erickson commented on SOLR-14534:
---
Thanks for the info. So far I've been OK b
rmuir commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-643283120
I like the new organization by having an optional parameter to `retrieve`.
But I think the exception handling can be simpler here? I think it would be
better to check the file
rmuir commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-643285331
i'm proposing something like this for the new method:
```
if (expectedLength < footerLength()) {
throw new IllegalArgumentException("expectedLength cannot be less tha
[
https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134248#comment-17134248
]
Erick Erickson commented on SOLR-11973:
---
We're getting perilously close to having w
[
https://issues.apache.org/jira/browse/LUCENE-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134249#comment-17134249
]
Jun Ohtani commented on LUCENE-9390:
I counted 3 types of words in ipadic csv files.
jpountz commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-643292082
I liked doing the suppressed dance to still get information about the shape
of the footer, e.g. for the case when the footer would be correct but the
length retrieved from t
rmuir commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-643294631
How would the length in the meta file be incorrect? It comes from a
checksum-verified file, right?
I think with the current PR, you'll get a somewhat confusing exception
jpountz commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-643297559
I think it's doing the opposite actually:
```
CorruptIndexException("truncated file: length=" + in.length() + " but
expectedLength==" + expectedLength, in)
|-
[
https://issues.apache.org/jira/browse/LUCENE-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134249#comment-17134249
]
Jun Ohtani edited comment on LUCENE-9390 at 6/12/20, 2:45 PM:
[
https://issues.apache.org/jira/browse/SOLR-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134281#comment-17134281
]
David Smiley commented on SOLR-14384:
-
I'm inclined to merge the PR as-is for master
rmuir commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-643316427
Yeah, you are right, its not that bad. But still i would prefer to just
deliver the clear exception without adding a less-clear suppressed one.
--
[
https://issues.apache.org/jira/browse/SOLR-14563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134292#comment-17134292
]
ASF subversion and git services commented on SOLR-14563:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-14563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134291#comment-17134291
]
ASF subversion and git services commented on SOLR-14563:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-14563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14563.
---
Fix Version/s: 8.6
Resolution: Fixed
> Fix or suppress warnings in solr/contrib
>
s1monw opened a new pull request #1573:
URL: https://github.com/apache/lucene-solr/pull/1573
Several classes within the IndexWriter indexing chain haven't been touched
for several years. Most of these classes expose their internals through public
members and are difficult to construct in t
[
https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134323#comment-17134323
]
Haoyu Zhai commented on LUCENE-8574:
Sry, wrong commit message pointed to here, the
mikemccand commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r439492017
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4483,6 +4593,7 @@ public int length() {
// Merge would
Jason Gerlowski created SOLR-14566:
--
Summary: Record "NOW" on "coordinator" log messages
Key: SOLR-14566
URL: https://issues.apache.org/jira/browse/SOLR-14566
Project: Solr
Issue Type: Impro
gerlowskija opened a new pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574
# Description
When reading through logs, associating the log message from the coordinator
node with the messages for per-shard requests downstream can be difficult.
Nothing unique (or
[
https://issues.apache.org/jira/browse/SOLR-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134368#comment-17134368
]
Jason Gerlowski commented on SOLR-14566:
I created a PR that takes the "NOW" appr
[
https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134377#comment-17134377
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-11973:
--
+1 to the id
[
https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134397#comment-17134397
]
Jason Gerlowski commented on SOLR-11973:
It sounds like a Good Thing to me. Thou
[
https://issues.apache.org/jira/browse/LUCENE-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134428#comment-17134428
]
Jun Ohtani commented on LUCENE-9390:
I also checked *UniDic* around punctuation char
[
https://issues.apache.org/jira/browse/LUCENE-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134428#comment-17134428
]
Jun Ohtani edited comment on LUCENE-9390 at 6/12/20, 5:53 PM:
[
https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134436#comment-17134436
]
Michael Gibney commented on SOLR-13132:
---
Ah, no worries! Though in light of this di
[
https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134455#comment-17134455
]
Erick Erickson commented on SOLR-11973:
---
Thanks Tomás and Jason.
Tomás:
Hmmm, yes
[
https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134505#comment-17134505
]
Lucene/Solr QA commented on LUCENE-9389:
| (x) *{color:red}-1 overall{color}* |
msokolov commented on pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-643476200
Test case #1 above, at least does reproduce (and #4 looks like a similar
stack trace; I did not try it):
gradlew :lucene:core:test --tests
"org.apache.lucene.ind
s1monw commented on pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-643486962
@mikemccand thanks for replying to all these comments. I do understand that
this change has an impact and I agree we should add this functionality. I just
disagree with the h
s1monw commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r439646326
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
##
@@ -109,6 +110,9 @@
/** Default value for whether calls to
s1monw commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r439646861
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -3257,6 +3320,52 @@ private long prepareCommitInternal() throws IOExc
s1monw commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r439647024
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -3228,15 +3268,38 @@ private long prepareCommitInternal() throws IOEx
s1monw commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r439647267
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4483,6 +4593,7 @@ public int length() {
// Merge would prod
mikemccand commented on pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-643496306
> @mikemccand thanks for replying to all these comments. I do understand
that this change has an impact and I agree we should add this functionality. I
just disagree with
msokolov commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r439657240
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
##
@@ -109,6 +110,9 @@
/** Default value for whether calls t
msokolov commented on pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-643498821
Re those test failures: I was able to fix by checking for an empty merge and
not submitting it.
This is an
murblanc opened a new pull request #1575:
URL: https://github.com/apache/lucene-solr/pull/1575
# Description
Fix TestZKPropertiesWriter that relied on legacy features of the SolrCloud
cluster to work. These features were removed.
# Solution
Start a MiniSolrCloudClus
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134591#comment-17134591
]
Ilan Ginzburg commented on SOLR-12823:
--
I have learned quite a bit on how SolrCloud
[
https://issues.apache.org/jira/browse/SOLR-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14565.
---
Fix Version/s: 8.6
Resolution: Fixed
> Fix or suppress warnings in solrj/impl and solr
[
https://issues.apache.org/jira/browse/SOLR-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134601#comment-17134601
]
ASF subversion and git services commented on SOLR-14565:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134599#comment-17134599
]
ASF subversion and git services commented on SOLR-14565:
Commit 6
tflobbe commented on a change in pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439686403
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -1259,6 +1277,20 @@ public SolrCore create(String coreName, Path
insta
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Klibisz updated LUCENE-9378:
-
Attachment: image-2020-06-12-22-17-30-339.png
> Configurable compression for BinaryDocValues
> -
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Klibisz updated LUCENE-9378:
-
Attachment: image-2020-06-12-22-17-53-961.png
> Configurable compression for BinaryDocValues
> -
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Klibisz updated LUCENE-9378:
-
Attachment: image-2020-06-12-22-18-24-527.png
> Configurable compression for BinaryDocValues
> -
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Klibisz updated LUCENE-9378:
-
Attachment: image-2020-06-12-22-18-48-919.png
> Configurable compression for BinaryDocValues
> -
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134629#comment-17134629
]
Alex Klibisz commented on LUCENE-9378:
--
Hi, just as another datapoint:
I'm using B
68 matches
Mail list logo
