[
https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134377#comment-17134377
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-11973:
------------------------------------------------------
+1 to the idea. Thanks for taking on this huge tasks. My thoughts:
bq. Should this be master-only or include 8x?
I think master only should be fine. 8.x would be a bonus and would make the
code similar which makes backporting easier, but I would be fine if it's not
done there. I don't know if there are differences in warnings between java 11
and 8 (which 8.x needs to support) that could complicate things.
bq. Gradle-only or both Gradle and Ant? I propose both if it's easy.
Agree, both if it's easy. Gradle is more important IMO, Ant is optional if we
don't do 8.x
bq. 4> Solr and Lucene both? I propose both.
+1. Maybe this issue should be turned into a LUCENE one? although the email to
the dev list should alert everyone anyways.
> Selectively fail on precommit WARN messages
> -------------------------------------------
>
> Key: SOLR-11973
> URL: https://issues.apache.org/jira/browse/SOLR-11973
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
>
> Not quite sure whether this qualifies as something for Solr or Lucene....
> I'm working gradually on getting precommit lint warnings out of the code
> base. I'd like to selectively fail a subtree once it's clean. I played around
> a bit with Robert's suggestions on the dev list but couldn't quite get it to
> work, then decided I needed to focus on one thing at a time.
> See SOLR-10809 for the first clean directory Real Soon Now.
> Bonus points would be working out how to fail on deprecation warnings when
> building Solr too, although that's farther off in the future.
> Assigning to myself, but anyone who knows the build ins and outs _please_
> feel free to take it!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
