[
https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134455#comment-17134455
]
Erick Erickson commented on SOLR-11973:
---------------------------------------
Thanks Tomás and Jason.
Tomás:
Hmmm, yes, perhaps a Lucene Jira or, perhaps, one in Solr and one in Lucene and
we can turn this on separately.
Jason:
Yeah, a lot depends on exactly how annoying it will be. I have to point that
IntelliJ (and, I assume Ecplise and NetBeans) highlights all of these as you
edit rather than leave them as something to clean up later. And the
"build>recompile blah.java" will bring up the errors in a convenient window you
can click on. And the "assemble" or "classes" task in the gradle window also
points out all of these from within the IDE. I suppose that if people turn off
the compile and then don't clean up after themselves, the immediate compile
failures on Jenkins will shame them into taking more care so turning them off
easily isn't a problem ;). I'll see if I can.
And there are 21 classes that have a warning about classes that define equals
but not hashCode(), which can be a source of subtle bugs.
Other than that, though, it's somewhat of a leap of faith. This pass probably
won't fix anything, I claim that by and large, the bugs that would have been
flagged were fixed already...painfully. If we tightened up our typing, I
suspect we wouldn't have had as many "cannot cast" exceptions as we've had but
I've no hard evidence that that's true. And this pass isn't doing anything
about that anyway.
> Selectively fail on precommit WARN messages
> -------------------------------------------
>
> Key: SOLR-11973
> URL: https://issues.apache.org/jira/browse/SOLR-11973
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
>
> Not quite sure whether this qualifies as something for Solr or Lucene....
> I'm working gradually on getting precommit lint warnings out of the code
> base. I'd like to selectively fail a subtree once it's clean. I played around
> a bit with Robert's suggestions on the dev list but couldn't quite get it to
> work, then decided I needed to focus on one thing at a time.
> See SOLR-10809 for the first clean directory Real Soon Now.
> Bonus points would be working out how to fail on deprecation warnings when
> building Solr too, although that's farther off in the future.
> Assigning to myself, but anyone who knows the build ins and outs _please_
> feel free to take it!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
