[
https://issues.apache.org/jira/browse/SOLR-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134397#comment-17134397
]
Jason Gerlowski commented on SOLR-11973:
----------------------------------------
It sounds like a Good Thing to me. Though I reserve the right to change my
mind once it's turned on and we see how annoying it might be :P
One caveat: when you set this up in ant/gradle, can there be an easy way to
disable it? It'd suck if I had to fix warnings in my code just to {{ant
server}} as the first step in running a manual test.
One question: I think there's this common-sense idea that eliminating warnings
improves code quality. And that makes sense, but it's nebulous. I'm just
curious - have you found any concrete examples that make the benefit here more
tangible? Any bugs you've found in the course of resolving these warnings?
Any resource leaks? etc. Just curious what you experience has been.
> Selectively fail on precommit WARN messages
> -------------------------------------------
>
> Key: SOLR-11973
> URL: https://issues.apache.org/jira/browse/SOLR-11973
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
>
> Not quite sure whether this qualifies as something for Solr or Lucene....
> I'm working gradually on getting precommit lint warnings out of the code
> base. I'd like to selectively fail a subtree once it's clean. I played around
> a bit with Robert's suggestions on the dev list but couldn't quite get it to
> work, then decided I needed to focus on one thing at a time.
> See SOLR-10809 for the first clean directory Real Soon Now.
> Bonus points would be working out how to fail on deprecation warnings when
> building Solr too, although that's farther off in the future.
> Assigning to myself, but anyone who knows the build ins and outs _please_
> feel free to take it!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
