github-actions[bot] commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2779945929
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
kaivalnp commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2730545360
Exciting change! Since this PR adds a new codec for vector search, I wanted
to point to #14178 along similar lines -- adding a new Faiss-based KNN format
to index and query vectors
ChrisHegarty commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2659128547
I just committed a rewrite for the cuVS format implementation.
After the rewrite all the BaseKnnVectorsFormatTestCase tests pass. There are
still some lurking intermittent fai
ChrisHegarty commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2656061680
> I think bumping main only for each non LTS release would be cool. Then we
keep it at the next LTS (Java 25)?
I filed the following issue to help facilitate the discussion re
benwtrent commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2643506891
I think bumping main only for each non LTS release would be cool. Then we
keep it at the next LTS (Java 25)?
Or, if its just as long from Lucene 10 -> 11, more likely the next LT
rmuir commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2643455016
> P.S. I'd like to bite into the apple and make Java 22 minimum requirement.
At least for main branch what is the harm? could we do 23 or 24? I'd really
like https://openjdk.org/jeps
benwtrent commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1946795551
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/vectorsearch/CuVSKnnFloatVectorQuery.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundatio
chatman commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1945235820
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/vectorsearch/CuVSKnnFloatVectorQuery.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation
ChrisHegarty commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2633256419
I've made the cuvs-java api Java 21 friendly, with an spi and a java-22
specific impl in the versioned section of an mrjar - MemorySegment and Arena
have been removed from the api,
chatman commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615867677
> I want to start cleaning some of the outstanding items in this PR, but I
do not have push access to SearchScale:cuvs-integration-main. Can I get access,
or is there a better way to pro
chatman commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615875009
>
restructure cuvs-java so that it compiles to a minimum JDK 21, with an mr
jar/version specific loading. Maybe it can even strip use class file version 65
and strip the preview
uschindler commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615941784
One additional important thing: no public API in this new Lucene
module/codec must export any preview API, so it must all be private/pkg-private.
--
This is an automated message fro
ChrisHegarty commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615930453
> P.P.S. Elasticsearch has a Gradle plugin to strip preview flags. Basically
it patches one byte in all class files that are created by Javac.
Yes, we can do this. Along with
ChrisHegarty commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615927388
> Tha APIs are available in Java 21, too (with minimal changes regarding
some specific parts like string handling). If you omit those, you can compile
against java 21 and later stri
uschindler commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615924479
P.P.S. Elasticsearch has a Gradle plugin to strip preview flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
benwtrent commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615923918
@dweiss While I think that might work for unused/snapshot Lucene releases, I
think @chatman et. al. is aiming for usage in the current Lucene Main so that
Lucene focused search engines
uschindler commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615909166
> > restructure cuvs-java so that it compiles to a minimum JDK 21, with an
mr jar/version specific loading. Maybe it can even strip use class file version
65 and strip the preview bit
dweiss commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615902695
The third option is to bump the minimum Java requirement to Java 22 on main?
I know it's an interim release but maybe we should just do it, anticipating the
next major lts (due to be rele
ChrisHegarty commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615430123
I want to start cleaning some of the outstanding items in this PR, but I do
not have push access to SearchScale:cuvs-integration-main. Can I get access, or
is there a better way to
ChrisHegarty commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615395910
Hi, `cuvs-java-25.02` is currently compiled with JDK 22, so has a minimum
class file version of 66. Lucene compiles with a minimum of JDK 21, class file
version 65. The reason why
uschindler commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1922705455
##
lucene/sandbox/src/java/module-info.java:
##
@@ -20,6 +20,9 @@
requires org.apache.lucene.core;
requires org.apache.lucene.queries;
requires org.apache.
uschindler commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1922703919
##
lucene/sandbox/src/java/module-info.java:
##
@@ -20,6 +20,9 @@
requires org.apache.lucene.core;
requires org.apache.lucene.queries;
requires org.apache.
ChrisHegarty commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1922626291
##
lucene/sandbox/src/java/module-info.java:
##
@@ -20,6 +20,9 @@
requires org.apache.lucene.core;
requires org.apache.lucene.queries;
requires org.apach
uschindler commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1922618477
##
lucene/sandbox/src/java/module-info.java:
##
@@ -20,6 +20,9 @@
requires org.apache.lucene.core;
requires org.apache.lucene.queries;
requires org.apache.
uschindler commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1922618477
##
lucene/sandbox/src/java/module-info.java:
##
@@ -20,6 +20,9 @@
requires org.apache.lucene.core;
requires org.apache.lucene.queries;
requires org.apache.
ChrisHegarty commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1922550039
##
lucene/sandbox/src/java/module-info.java:
##
@@ -20,6 +20,9 @@
requires org.apache.lucene.core;
requires org.apache.lucene.queries;
requires org.apach
dweiss commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1920628250
##
build-tools/build-infra/build.gradle:
##
@@ -22,6 +22,7 @@ plugins {
}
repositories {
+ mavenLocal()
Review Comment:
I think you can skip the entire task th
chatman commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2598991862
> I haven't touched on the validity of having an NVIDIA only GPU backed
index in Lucene sandbox directly. The new dependencies are huge. IDK if
whomever downloads and builds lucene then
chatman commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1920607152
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/vectorsearch/CuVSVectorsWriter.java:
##
@@ -0,0 +1,402 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chatman commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2598981931
> @chatman thanks for creating the PR. This looks very interesting. is the
idea here is the Lucene library will on a GPU machine and running the CUVS.
Yes, exactly.
--
This is a
chatman commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1920605331
##
build-tools/build-infra/build.gradle:
##
@@ -22,6 +22,7 @@ plugins {
}
repositories {
+ mavenLocal()
Review Comment:
Sure, Dawid, will add a nocommit comme
chatman commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2598979683
> This seems pretty far from ready yet. I left some comments on some glaring
issues. However, there are other things like:
>
> * tests for queries
>
> * tests for th
benwtrent commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1914748083
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/vectorsearch/CuVSVectorsWriter.java:
##
@@ -0,0 +1,402 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
navneet1v commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1911714546
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/vectorsearch/CuVSVectorsWriter.java:
##
@@ -0,0 +1,402 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
navneet1v commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2584809189
@chatman thanks for creating the PR. This looks very interesting. is the
idea here is the Lucene library will on a GPU machine and running the CUVS.
--
This is an automated message
dweiss commented on code in PR #14131:
URL: https://github.com/apache/lucene/pull/14131#discussion_r1911392570
##
build-tools/build-infra/build.gradle:
##
@@ -22,6 +22,7 @@ plugins {
}
repositories {
+ mavenLocal()
Review Comment:
Remove mavenLocal before merging, if it
chatman commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2582968787
FYI @uschindler, @ChrisHegarty, @dsmiley, @msokolov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
37 matches
Mail list logo
