ChrisHegarty commented on code in PR #14131: URL: https://github.com/apache/lucene/pull/14131#discussion_r1922626291
########## lucene/sandbox/src/java/module-info.java: ########## @@ -20,6 +20,9 @@ requires org.apache.lucene.core; requires org.apache.lucene.queries; requires org.apache.lucene.facet; + requires java.logging; + requires com.nvidia.cuvs; Review Comment: @uschindler Agree - this feature should be optional. If the Java API is present and loadable without the native library - has at least one callable method, which we can call and catch, then that is fine. I'll try it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
