uschindler commented on code in PR #14131: URL: https://github.com/apache/lucene/pull/14131#discussion_r1922618477
########## lucene/sandbox/src/java/module-info.java: ########## @@ -20,6 +20,9 @@ requires org.apache.lucene.core; requires org.apache.lucene.queries; requires org.apache.lucene.facet; + requires java.logging; + requires com.nvidia.cuvs; Review Comment: I don't see this in the snapshot module a problem. The code itsself should be written in a way that the codec can only be used, if the native library is there. Currently the code is a bit broken as it does not fail hard. I'd like to change this (see my review), But if the dependency is on Maven central, it should work. Of course we could make it also optional in module system, but then you would get CNFE when loading codecs or related classes, which would happen on SPI lookup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
