ChrisHegarty commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2615395910

   Hi,  `cuvs-java-25.02` is currently compiled with JDK 22, so has a minimum 
class file version of 66. Lucene compiles with a minimum of JDK 21, class file 
version 65.  The reason why cuvs-java has a minimum of JDK 22 is that is uses 
Panama/foreign APIs directly, which is fine.  
   
   We have two options here: 
   1. restructure cuvs-java so that it compiles to a minimum JDK 21, with an mr 
jar/version specific loading. Maybe it can even strip use class file version 65 
and strip the preview bit, similar to what Lucene does. Depends on the nature 
of what the code is doing - which I've yet to fully look into. All said, this 
is quite involved, but may make that cuvs-java api more generally useful.   ( 
one can at least develop against it more easily, if not run tests, etc )
   
   2. Restructure the code in Lucene so that it uses a toolchain and javac from 
JDK 22 and a `java22` sourceset. Also make it's loading conditional on the JDK 
version and/or use an mrjar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to