github-actions[bot] commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2784920720
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
jpountz commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2748960716
I've been thinking a bit more about this. The two potential use-cases that
come to mind are the following:
- Diverging from the way Lucene does memory management (off-heap / on-heap
javanna commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2729969364
I opened #14364 to make the suggested change to the completion postings
format, let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to t
jpountz commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2710617442
> @jpountz given the connection of this PR with completion FST, do you have
opinions here?
Sorry for the late reply.
If we want to allow configuring how a codec gets loaded
javanna commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2711741530
> But I'm still questioning if there's actually a use-case for allowing
something to be loaded either on-heap or off-heap in our codecs. For all
examples that come to mind, I would rathe
jpountz commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2714778925
> I do think that this is more generally useful, than just the particular
use case of on or off -heap FST in completion postings.
I'm curious of what other use-cases you have in mi
ChrisHegarty commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2713450274
I do think that this is more generally useful, than just the particular use
case of on or off -heap FST in completion postings.
> If we want to allow configuring how a codec g
ChrisHegarty commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2697094951
> My proposal would be: Let's add some key-value pairs of "codec options"
like done in Analyzers, that can be passed as part of the IndexWriterConfig
(while writing) or passed to Di
javanna commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2697098397
I agree with everything you wrote above @uschindler !
I can try and update my existing PR targeted at suggestion fields (#14270),
following your suggested approach. The PR current
uschindler commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2695637219
Hi,
> I will throw in a real usecase that gives us a bit of headache: completion
fields. All the existing codecs load them on heap, and we want to make a switch
to load them of
javanna commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2695424434
I will throw in a real usecase that gives us a bit of headache: completion
fields. All the existing codecs load them on heap, and we want to make a switch
to load them off heap in certai
ChrisHegarty commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2694804577
Yeah, I can see your point. What unsettles me a little about the proposed
change is the "weight" that it imposes on this simple SPI interface for a
somewhat niche issue. That said,
uschindler commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2694748030
But basically the whole idea here is to allow to replace codecs, which is in
reality not wanted at all. If you want a different codec, name it differently.
So you am not fully h
uschindler commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2694739987
Now I understand how this is expected to work. Elasticsearch will return
true for the SPI impl.
Maybe we should also try to allow different orders for the active discovery.
May
uschindler commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2694709538
Did you think about this one, too:
https://github.com/apache/lucene/blob/8e68ed22614dc7841ebea94d3e66561ceb74d25e/lucene/core/src/java/org/apache/lucene/analysis/AnalysisSPILoader.java
ChrisHegarty commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2694681847
Anyone else ? @uschindler ? I think that this is quite solid, and while the
issue we're facing in Elasticsearch is because we deploy as modules, it may not
be that widely encounter
ChrisHegarty commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2687787710
@jpountz given the connection of this PR with completion FST, do you have
opinions here?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
javanna commented on code in PR #14275:
URL: https://github.com/apache/lucene/pull/14275#discussion_r1971311446
##
lucene/core/src/java/org/apache/lucene/util/NamedSPILoader.java:
##
@@ -64,18 +64,24 @@ public NamedSPILoader(Class clazz, ClassLoader
classloader) {
*/
pub
ChrisHegarty commented on code in PR #14275:
URL: https://github.com/apache/lucene/pull/14275#discussion_r1971253531
##
lucene/core/src/java/org/apache/lucene/util/NamedSPILoader.java:
##
@@ -64,18 +64,24 @@ public NamedSPILoader(Class clazz, ClassLoader
classloader) {
*/
javanna commented on code in PR #14275:
URL: https://github.com/apache/lucene/pull/14275#discussion_r1971187231
##
lucene/core/src/java/org/apache/lucene/util/NamedSPILoader.java:
##
@@ -64,18 +64,24 @@ public NamedSPILoader(Class clazz, ClassLoader
classloader) {
*/
pub
ChrisHegarty commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2676407372
> Is it that this switches from "first one wins" to "last one wins"?
Good q. Out of the box, the default remains unchanged - first one wins.
But if overridden, allows subseq
msokolov commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2676371365
Is it that this switches from "first one wins" to "last one wins"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
ChrisHegarty opened a new pull request, #14275:
URL: https://github.com/apache/lucene/pull/14275
This commit adds support load per-iteration replacement of NamedSPI. The
primary motivation for this change is to support deterministic SPI loading when
deploying Lucene as a module.
Whe
23 matches
Mail list logo
