gsmiller merged PR #13599:
URL: https://github.com/apache/lucene/pull/13599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
gsmiller commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2278737360
@jainankitk thanks for the iterations! I'm fine with making this change as
you currently having. I'll get it merged. Thanks!
--
This is an automated message from the Apache Git Servic
jainankitk commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2274473157
> I think it's a little clunky for the reader at the same time (it's a bit
strange to have to pass the same packed value point twice
Thanks @gsmiller for providing this feedback
gsmiller commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2272107532
In general, I really appreciate that you're looking for opportunities to
cleanup the codebase and find ways to avoid duplicated logic. Thanks
@jainankitk ! At the same time, I don't per
jainankitk closed pull request #13599: Delegating the matches in
PointRangeQuery weight to relate method
URL: https://github.com/apache/lucene/pull/13599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jainankitk commented on code in PR #13599:
URL: https://github.com/apache/lucene/pull/13599#discussion_r1705858403
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -127,22 +127,8 @@ public final Weight createWeight(IndexSearcher searcher,
ScoreMode s
vigyasharma commented on code in PR #13599:
URL: https://github.com/apache/lucene/pull/13599#discussion_r1693377964
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -127,22 +127,8 @@ public final Weight createWeight(IndexSearcher searcher,
ScoreMode
jainankitk commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2253092184
> what do you think of my comment above, would you agree that this change
makes the matches method more expensive?
Probably. I have tweaked the code to avoid the below check. Le
iverase commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2252263122
what do you think of my comment above, would you agree that this change
makes the matches method more expensive?
I think what you propose is anti-pattern for the IntersectsVisitor
jainankitk commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2252141138
> I am afraid those benchmarks hardly exercise the change you are proposing
so they will not show anything.
Do you have anything specific in mind?
--
This is an automated mes
iverase commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2252095426
I am afraid those benchmarks hardly exercise the change you are proposing so
they will not show anything.
--
This is an automated message from the Apache Git Service.
To respond to th
jainankitk commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2251571896
Overall, I am not seeing any performance regression from the benchmark or
memory/cpu profiles. Please let me know, in case I am missing something.
--
This is an automated message fr
jainankitk commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2251568527
Memory profile:
BASELINE:
```
PROFILE SUMMARY from 78943 events (total: 98729M)
tests.profile.mode=he
jainankitk commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2251567510
Also, adding the cpu/memory profile below:
BASELINE:
```
PROFILE SUMMARY from 1922337 events (total: 1M)
jainankitk commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2251565833
@iverase - Adding the benchmark results below. I am not seeing any
performance regression:
```
TaskQPS baseline StdDevQPS
my_modified_versio
iverase commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2247049079
If we look at the current implementation of matches and relates, they both
iterate over the dimensions and they both check if the dimension is disjoint.
If that is true, then they bail o
harshavamsi commented on PR #13599:
URL: https://github.com/apache/lucene/pull/13599#issuecomment-2245815063
> I would expect this change to result in a slow down for this type of
queries.
>
> You are proposing to replace the current implementation with a slower one
that computes the
jainankitk opened a new pull request, #13599:
URL: https://github.com/apache/lucene/pull/13599
### Description
Delegating the matches in PointRangeQuery weight to relate method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
18 matches
Mail list logo
