Re: [PR] Add histogram facet capabilities. [lucene]

jpountz merged PR #14204: URL: https://github.com/apache/lucene/pull/14204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add histogram facet capabilities. [lucene]

epotyom commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1959487538 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Add histogram facet capabilities. [lucene]

epotyom commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1959444929 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Add histogram facet capabilities. [lucene]

epotyom commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1958677872 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

epotyom commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1958677872 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

epotyom commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1958677872 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1958608604 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

epotyom commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1958022460 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

epotyom commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1958022460 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1954925602 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

stefanvodita commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1954612647 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1954905919 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

stefanvodita commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1954612647 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add histogram facet capabilities. [lucene]

gsmiller commented on PR #14204: URL: https://github.com/apache/lucene/pull/14204#issuecomment-2651798767 This looks good to me @jpountz. I think it makes sense to put this in sandbox, but I'd personally also be fine with leaving it where you initially had it. (I think this also highlights

Re: [PR] Add histogram facet capabilities. [lucene]

gsmiller commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1951323035 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Add histogram facet capabilities. [lucene]

epotyom commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1950866681 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on PR #14204: URL: https://github.com/apache/lucene/pull/14204#issuecomment-2650473311 I moved the code to the sandbox facet framework and applied suggestions, I hope I didn't miss any. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1949994957 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

gsmiller commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1949338012 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Add histogram facet capabilities. [lucene]

gsmiller commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1949346251 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Add histogram facet capabilities. [lucene]

stefanvodita commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1947963361 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1947961440 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1947960872 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

stefanvodita commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1947943381 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1947250254 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1947210099 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1947210099 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1947204762 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add histogram facet capabilities. [lucene]

gsmiller commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1945846299 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Add histogram facet capabilities. [lucene]

iverase commented on PR #14204: URL: https://github.com/apache/lucene/pull/14204#issuecomment-2640605039 >So I guess that the only option is to fail at runtime. I can do that. What looks like a reasonable cap on the number of returned intervals? 1024? 1024 sounds a good default and ma

Re: [PR] Add histogram facet capabilities. [lucene]

jpountz commented on PR #14204: URL: https://github.com/apache/lucene/pull/14204#issuecomment-2640553823 I agree that providing a small interval is a bad usage pattern. I don't know how to validate this though, since we can't know the range of values of the docs that match the query up-fron

Re: [PR] Add histogram facet capabilities. [lucene]

iverase commented on code in PR #14204: URL: https://github.com/apache/lucene/pull/14204#discussion_r1944680152 ## lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] Add histogram facet capabilities. [lucene]

jpountz opened a new pull request, #14204: URL: https://github.com/apache/lucene/pull/14204 This is inspired from a paper by Tencent where the authors describe how they speed up so-called "histogram queries" by sorting the index by timestamp and translating ranges of values corresponding to