jpountz commented on code in PR #14204:
URL: https://github.com/apache/lucene/pull/14204#discussion_r1958608604


##########
lucene/facet/src/java/org/apache/lucene/facet/histogram/HistogramCollector.java:
##########
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.facet.histogram;
+
+import java.io.IOException;
+import org.apache.lucene.index.DocValues;
+import org.apache.lucene.index.DocValuesSkipper;
+import org.apache.lucene.index.DocValuesType;
+import org.apache.lucene.index.FieldInfo;
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.index.NumericDocValues;
+import org.apache.lucene.index.SortedNumericDocValues;
+import org.apache.lucene.internal.hppc.LongIntHashMap;
+import org.apache.lucene.search.CollectionTerminatedException;
+import org.apache.lucene.search.Collector;
+import org.apache.lucene.search.LeafCollector;
+import org.apache.lucene.search.Scorable;
+import org.apache.lucene.search.ScoreMode;
+
+final class HistogramCollector implements Collector {

Review Comment:
   > So I suppose it's not too terrible to not allow NO_MORE_ORDS value when 
counting.
   
   I'm a bit confused as to what your suggestion is then. For instance if the 
value is -5 and the interval is 10, the bucket would be computer as 
`Math.floorDiv(-5, 10)`, which returns -1.
   
   Based on your points, it seems like the least fragile approach would be to 
make the facet cutter responsible for densifying bucket ordinals?
   
   So in the end, it would make sense to have two histogram implementations, 
one as a cutter, that densifies ordinals using a hash table that is similar to 
your branch, and another one as a raw collector manager for users who are 
interested in computing counts per histogram bucket but nothing else like this 
PR?
   
   > Are you running runGeoBench.cmd to get results?
   
   I'm running the geonames benchmark, that consists or running the 
`IndexGeoNames#main` then `SearchGeoNames#main`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to